From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Jens Axboe <axboe@kernel.dk>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Steve French <smfrench@gmail.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
Networking <netdev@vger.kernel.org>
Subject: Re: iwlwifi warnings in 5.5-rc1
Date: Wed, 11 Dec 2019 15:09:58 +0100 [thread overview]
Message-ID: <87o8wfeyx5.fsf@toke.dk> (raw)
In-Reply-To: <d4a48cbdc4b0db7b07b8776a1ee70b140e8a9bbf.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
> ++ others who reported this
>
> On Tue, 2019-12-10 at 13:46 -0700, Jens Axboe wrote:
>
>> ------------[ cut here ]------------
>> STA b4:75:0e:99:1f:e0 AC 2 txq pending airtime underflow: 4294967088, 208
>
> We think this is due to TSO, the change below will disable the AQL again
> for now until we can figure out how to really fix it. I think I'll do
> the equivalent for 5.5 and maybe leave it enabled only for ath10k, or
> something like that ...
If we're doing this on a per-driver basis, let's make it a proper
NL80211_EXT_FEATURE and expose it to userspace; that way users can at
least discover if it's supported on their device. I can send a patch
adding that...
Maybe we should untangle this from airtime_flags completely, since if we
just use the flags people could conceivably end up disabling it by
mistake, couldn't they?
-Toke
next prev parent reply other threads:[~2019-12-11 14:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 20:46 iwlwifi warnings in 5.5-rc1 Jens Axboe
2019-12-11 8:36 ` Johannes Berg
2019-12-11 8:53 ` Toke Høiland-Jørgensen
2019-12-11 10:11 ` Johannes Berg
2019-12-11 10:23 ` Toke Høiland-Jørgensen
2019-12-11 11:51 ` Johannes Berg
2019-12-11 13:42 ` Johannes Berg
2019-12-11 14:04 ` Toke Høiland-Jørgensen
2019-12-11 14:12 ` Johannes Berg
2019-12-11 14:47 ` Toke Høiland-Jørgensen
2019-12-11 21:18 ` Johannes Berg
2019-12-12 10:45 ` Toke Høiland-Jørgensen
2019-12-11 14:02 ` Toke Høiland-Jørgensen
2019-12-11 21:17 ` Johannes Berg
2019-12-12 10:55 ` Toke Høiland-Jørgensen
2019-12-12 11:00 ` Johannes Berg
2019-12-21 0:55 ` Jens Axboe
2019-12-21 9:17 ` Johannes Berg
2019-12-21 13:45 ` Jens Axboe
2019-12-11 13:45 ` Johannes Berg
2019-12-11 14:09 ` Toke Høiland-Jørgensen [this message]
2019-12-11 14:13 ` Johannes Berg
2019-12-11 14:55 ` Toke Høiland-Jørgensen
2019-12-11 21:19 ` Johannes Berg
2019-12-12 10:55 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8wfeyx5.fsf@toke.dk \
--to=toke@redhat.com \
--cc=Jason@zx2c4.com \
--cc=axboe@kernel.dk \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).