From: Kalle Valo <kvalo@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Robert Marko <robimarko@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, gregkh@linuxfoundation.org, elder@linaro.org,
hemantk@codeaurora.org, quic_jhugo@quicinc.com,
quic_qianyu@quicinc.com, bbhatt@codeaurora.org,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, ansuelsmth@gmail.com
Subject: Re: [PATCH 2/2] wifi: ath11k: use unique QRTR instance ID
Date: Tue, 08 Nov 2022 19:24:22 +0200 [thread overview]
Message-ID: <87cz9xcqbd.fsf@kernel.org> (raw)
In-Reply-To: <20221107174727.GA7535@thinkpad> (Manivannan Sadhasivam's message of "Mon, 7 Nov 2022 23:17:27 +0530")
Manivannan Sadhasivam <mani@kernel.org> writes:
> On Sat, Nov 05, 2022 at 08:49:43PM +0100, Robert Marko wrote:
>> Currently, trying to use AHB + PCI/MHI cards or multiple PCI/MHI cards
>> will cause a clash in the QRTR instance node ID and prevent the driver
>> from talking via QMI to the card and thus initializing it with:
>> [ 9.836329] ath11k c000000.wifi: host capability request failed: 1 90
>> [ 9.842047] ath11k c000000.wifi: failed to send qmi host cap: -22
>>
>
> There is still an outstanding issue where you cannot connect two WLAN modules
> with same node id.
>
>> So, in order to allow for this combination of cards, especially AHB + PCI
>> cards like IPQ8074 + QCN9074 (Used by me and tested on) set the desired
>> QRTR instance ID offset by calculating a unique one based on PCI domain
>> and bus ID-s and writing it to bits 7-0 of BHI_ERRDBG2 MHI register by
>> using the SBL state callback that is added as part of the series.
>> We also have to make sure that new QRTR offset is added on top of the
>> default QRTR instance ID-s that are currently used in the driver.
>>
>
> Register BHI_ERRDBG2 is listed as Read only from Host as per the BHI spec.
> So I'm not sure if this solution is going to work on all ath11k supported
> chipsets.
>
> Kalle, can you confirm?
I can't look at this in detail right now, but hopefully in few days.
I'll get back to you.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-11-08 17:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 19:49 [PATCH 1/2] bus: mhi: core: add SBL state callback Robert Marko
2022-11-05 19:49 ` [PATCH 2/2] wifi: ath11k: use unique QRTR instance ID Robert Marko
2022-11-07 15:09 ` Jeffrey Hugo
2022-11-07 17:15 ` Robert Marko
2022-11-07 17:47 ` Manivannan Sadhasivam
2022-11-07 17:52 ` Robert Marko
2022-11-07 18:02 ` Jeffrey Hugo
2022-11-08 17:24 ` Kalle Valo [this message]
2022-11-22 11:26 ` Kalle Valo
2022-12-14 12:02 ` Robert Marko
2022-12-22 13:57 ` Kalle Valo
2023-01-11 9:21 ` Robert Marko
2023-01-11 17:09 ` Kalle Valo
2023-01-11 17:10 ` Robert Marko
2023-01-12 9:40 ` Kalle Valo
2023-01-12 9:43 ` Robert Marko
2023-01-12 9:48 ` Kalle Valo
2023-01-23 19:21 ` Robert Marko
2023-03-08 12:43 ` Kalle Valo
2023-04-26 12:40 ` Robert Marko
2022-11-07 11:27 ` [PATCH 1/2] bus: mhi: core: add SBL state callback Manivannan Sadhasivam
2022-11-07 11:31 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz9xcqbd.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=ath11k@lists.infradead.org \
--cc=bbhatt@codeaurora.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_jhugo@quicinc.com \
--cc=quic_qianyu@quicinc.com \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).