From: Robert Marko <robimarko@gmail.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: Robert Marko <robert.marko@sartura.hr>,
Manivannan Sadhasivam <mani@kernel.org>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, gregkh@linuxfoundation.org, elder@linaro.org,
hemantk@codeaurora.org, quic_jhugo@quicinc.com,
quic_qianyu@quicinc.com, bbhatt@codeaurora.org,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, ansuelsmth@gmail.com
Subject: Re: [PATCH 2/2] wifi: ath11k: use unique QRTR instance ID
Date: Wed, 26 Apr 2023 14:40:32 +0200 [thread overview]
Message-ID: <CAOX2RU5EaRrcKW7uhmDQbUO-TzOOnKAsx5HKtRjMDTMBEZj4tA@mail.gmail.com> (raw)
In-Reply-To: <87fsafpg63.fsf@kernel.org>
> Still not sure what you mean. Are you saying that this patch under
> discussion ("wifi: ath11k: use unique QRTR instance ID") also works with
> QCA6390 and it's possible to connect two QCA6390 devices on the same
> host?
>
> Or are you referring to some other hack? Or have I totally
> misunderstood? :)
We probably have a misunderstanding, QCA6390 does not work with
("wifi: ath11k: use unique QRTR instance ID"), that is why we in OpenWrt
limited it to QCN9074 only so far.
>
> > so that is why its quite important for OpenWrt to have a generic
> > solution that works on all cards.
>
> I fully agree on importance of having a generic solution. It's just sad
> that it seems people who designed this didn't consider about having
> multiple devices on the same host. It looks like there's no easy way to
> implement a generic solution, we have only bad choices to choose from.
> Your solution[1] is racy and writing to a register which is marked as
> read-only in the spec.
I agree, this is purely a hack based on what QCA is doing downstream where
they hardcode the QRTR ID in DTS and write to the same register.
>
> Qualcomm's solution[2] needs changes in firmware and it's uncertain if
> I'm able to convince all firmware teams to implement the support.
> (Currently only QCN9074 firmware supports this.)
>
> Thoughts?
I mean, we need some kind of a solution cause trying to pitch using a QCA
AX SoC-s and PCI cards but then saying that they cannot use AHB+PCI
or multiple PCI cards at the same time are not viable.
Regards,
Robert
>
> [1] https://patchwork.kernel.org/project/linux-wireless/patch/20221105194943.826847-2-robimarko@gmail.com/
>
> [2] https://patchwork.kernel.org/project/linux-wireless/patch/20230111170033.32454-1-kvalo@kernel.org/
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-04-26 12:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 19:49 [PATCH 1/2] bus: mhi: core: add SBL state callback Robert Marko
2022-11-05 19:49 ` [PATCH 2/2] wifi: ath11k: use unique QRTR instance ID Robert Marko
2022-11-07 15:09 ` Jeffrey Hugo
2022-11-07 17:15 ` Robert Marko
2022-11-07 17:47 ` Manivannan Sadhasivam
2022-11-07 17:52 ` Robert Marko
2022-11-07 18:02 ` Jeffrey Hugo
2022-11-08 17:24 ` Kalle Valo
2022-11-22 11:26 ` Kalle Valo
2022-12-14 12:02 ` Robert Marko
2022-12-22 13:57 ` Kalle Valo
2023-01-11 9:21 ` Robert Marko
2023-01-11 17:09 ` Kalle Valo
2023-01-11 17:10 ` Robert Marko
2023-01-12 9:40 ` Kalle Valo
2023-01-12 9:43 ` Robert Marko
2023-01-12 9:48 ` Kalle Valo
2023-01-23 19:21 ` Robert Marko
2023-03-08 12:43 ` Kalle Valo
2023-04-26 12:40 ` Robert Marko [this message]
2022-11-07 11:27 ` [PATCH 1/2] bus: mhi: core: add SBL state callback Manivannan Sadhasivam
2022-11-07 11:31 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOX2RU5EaRrcKW7uhmDQbUO-TzOOnKAsx5HKtRjMDTMBEZj4tA@mail.gmail.com \
--to=robimarko@gmail.com \
--cc=ansuelsmth@gmail.com \
--cc=ath11k@lists.infradead.org \
--cc=bbhatt@codeaurora.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_jhugo@quicinc.com \
--cc=quic_qianyu@quicinc.com \
--cc=robert.marko@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).