From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, David Ahern <dsahern@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH RFC v2] net: xdp: allow for layer 3 packets in generic skb handler
Date: Mon, 27 Apr 2020 22:08:58 +0200 [thread overview]
Message-ID: <87ftcoy9lx.fsf@toke.dk> (raw)
In-Reply-To: <CAHmME9oygxd=Sa5PvXWYm7Mth4tc_LfqnZXM+XrHuouKP1AQxg@mail.gmail.com>
"Jason A. Donenfeld" <Jason@zx2c4.com> writes:
> On Mon, Apr 27, 2020 at 8:45 AM David Ahern <dsahern@gmail.com> wrote:
>>
>> On 4/27/20 4:22 AM, Jason A. Donenfeld wrote:
>> > @@ -4544,6 +4544,13 @@ static u32 netif_receive_generic_xdp(struct sk_buff *skb,
>> > * header.
>> > */
>> > mac_len = skb->data - skb_mac_header(skb);
>> > + if (!mac_len) {
>> > + add_eth_hdr = true;
>> > + mac_len = sizeof(struct ethhdr);
>> > + *((struct ethhdr *)skb_push(skb, mac_len)) = (struct ethhdr) {
>> > + .h_proto = skb->protocol
>> > + };
>>
>> please use a temp variable and explicit setting of the fields; that is
>> not pleasant to read and can not be more performant than a more direct
>>
>> eth_zero_addr(eth->h_source);
>> eth_zero_addr(eth->h_dest);
>> eth->h_proto = skb->protocol;
>
> Ack, will change for the non-RFC v3 patch. I need to actually figure
> out how to test this thing first though...
You could try the xdp-filter application in this repo:
https://github.com/xdp-project/xdp-tools
(make sure you use --recurse-submodules when you clone it)
That will allow you to install simple IP- and port-based filters; should
be enough to check that XDP programs will correctly match the packet
contents, I think?
-Toke
next prev parent reply other threads:[~2020-04-27 20:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 1:10 [PATCH RFC v1] net: xdp: allow for layer 3 packets in generic skb handler Jason A. Donenfeld
2020-04-27 7:20 ` Toke Høiland-Jørgensen
2020-04-27 10:05 ` Jason A. Donenfeld
2020-04-27 10:22 ` [PATCH RFC v2] " Jason A. Donenfeld
2020-04-27 11:16 ` Toke Høiland-Jørgensen
2020-04-27 14:45 ` David Ahern
2020-04-27 19:58 ` Jason A. Donenfeld
2020-04-27 20:08 ` Toke Høiland-Jørgensen [this message]
2020-04-27 20:10 ` Jason A. Donenfeld
2020-04-27 20:42 ` [PATCH net v3] net: xdp: account " Jason A. Donenfeld
2020-04-27 20:52 ` Jakub Kicinski
2020-04-27 20:57 ` Jason A. Donenfeld
2020-04-27 21:00 ` Jakub Kicinski
2020-04-27 21:08 ` Jason A. Donenfeld
2020-04-27 21:19 ` Jakub Kicinski
2020-04-27 21:14 ` Toke Høiland-Jørgensen
2020-04-27 21:31 ` Jakub Kicinski
2020-04-27 23:00 ` Jason A. Donenfeld
2020-04-27 23:45 ` Jason A. Donenfeld
2020-04-28 0:15 ` Jakub Kicinski
2020-04-28 0:17 ` Jason A. Donenfeld
2020-04-28 0:40 ` Jakub Kicinski
2020-04-28 9:27 ` Toke Høiland-Jørgensen
2020-04-28 16:51 ` Jakub Kicinski
2020-04-28 17:03 ` Alexei Starovoitov
2020-04-27 21:00 ` Toke Høiland-Jørgensen
2020-04-27 10:30 ` [PATCH RFC v1] net: xdp: allow " Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftcoy9lx.fsf@toke.dk \
--to=toke@redhat.com \
--cc=Jason@zx2c4.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).