From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
Netdev <netdev@vger.kernel.org>,
"Adhipati Blambangan" <adhipati@tuta.io>,
"David Ahern" <dsahern@gmail.com>
Subject: Re: [PATCH net v3] net: xdp: account for layer 3 packets in generic skb handler
Date: Mon, 27 Apr 2020 18:17:16 -0600 [thread overview]
Message-ID: <CAHmME9rr2vnCgULXEF4pPyUNU2N6g3yomPBA6mzArnPMc8kDSw@mail.gmail.com> (raw)
In-Reply-To: <20200427171536.31a89664@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Apr 27, 2020 at 6:15 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 27 Apr 2020 17:45:12 -0600 Jason A. Donenfeld wrote:
> > > Okay, well, I'll continue developing the v3 approach a little further
> > > -- making sure I have tx path handled too and whatnot. Then at least
> > > something viable will be available, and you can take or leave it
> > > depending on what you all decide.
> >
> > Actually, it looks like egress XDP still hasn't been merged. So I
> > think this patch should be good to go in terms of what it is.
>
> TX and redirect don't require the XDP egress hook to function.
Oh, you meant the TX and redirect actions returned from the ingress
hook. Gotcha. The paths that those take don't appear to rely on having
the fake header though, whereas the actual xdp_progs that run do rely
on that, which is why it's added there.
next prev parent reply other threads:[~2020-04-28 0:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 1:10 [PATCH RFC v1] net: xdp: allow for layer 3 packets in generic skb handler Jason A. Donenfeld
2020-04-27 7:20 ` Toke Høiland-Jørgensen
2020-04-27 10:05 ` Jason A. Donenfeld
2020-04-27 10:22 ` [PATCH RFC v2] " Jason A. Donenfeld
2020-04-27 11:16 ` Toke Høiland-Jørgensen
2020-04-27 14:45 ` David Ahern
2020-04-27 19:58 ` Jason A. Donenfeld
2020-04-27 20:08 ` Toke Høiland-Jørgensen
2020-04-27 20:10 ` Jason A. Donenfeld
2020-04-27 20:42 ` [PATCH net v3] net: xdp: account " Jason A. Donenfeld
2020-04-27 20:52 ` Jakub Kicinski
2020-04-27 20:57 ` Jason A. Donenfeld
2020-04-27 21:00 ` Jakub Kicinski
2020-04-27 21:08 ` Jason A. Donenfeld
2020-04-27 21:19 ` Jakub Kicinski
2020-04-27 21:14 ` Toke Høiland-Jørgensen
2020-04-27 21:31 ` Jakub Kicinski
2020-04-27 23:00 ` Jason A. Donenfeld
2020-04-27 23:45 ` Jason A. Donenfeld
2020-04-28 0:15 ` Jakub Kicinski
2020-04-28 0:17 ` Jason A. Donenfeld [this message]
2020-04-28 0:40 ` Jakub Kicinski
2020-04-28 9:27 ` Toke Høiland-Jørgensen
2020-04-28 16:51 ` Jakub Kicinski
2020-04-28 17:03 ` Alexei Starovoitov
2020-04-27 21:00 ` Toke Høiland-Jørgensen
2020-04-27 10:30 ` [PATCH RFC v1] net: xdp: allow " Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9rr2vnCgULXEF4pPyUNU2N6g3yomPBA6mzArnPMc8kDSw@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=adhipati@tuta.io \
--cc=dsahern@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).