From: "Bjørn Mork" <bjorn@mork.no>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Kristian Evensen <kristian.evensen@gmail.com>,
netdev@vger.kernel.org, subashab@codeaurora.org
Subject: Re: [PATCH net] qmi_wwan: Clone the skb when in pass-through mode
Date: Tue, 15 Jun 2021 08:24:39 +0200 [thread overview]
Message-ID: <87pmwnwspk.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20210614130530.7a422f27@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (Jakub Kicinski's message of "Mon, 14 Jun 2021 13:05:30 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> It does look pretty strange that qmimux_rx_fixup() copies out all
> packets and receives them, and then let's usbnet to process the
> multi-frame skb without even fulling off the qmimux_hdr. I'm probably
> missing something.. otherwise sth like FLAG_MULTI_PACKET may be in
> order?
Yes, maybe it is? We'd have to call usbnet_skb_return() for the plain
IP frames then, but that might come out cleaner?
Bjørn
next prev parent reply other threads:[~2021-06-15 6:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 14:18 [PATCH net] qmi_wwan: Clone the skb when in pass-through mode Kristian Evensen
2021-06-14 14:45 ` Bjørn Mork
2021-06-14 15:49 ` Kristian Evensen
2021-06-14 17:02 ` Kristian Evensen
2021-06-14 20:05 ` Jakub Kicinski
2021-06-15 6:24 ` Bjørn Mork [this message]
2021-06-15 9:03 ` Kristian Evensen
2021-06-15 10:04 ` Bjørn Mork
2021-06-15 10:51 ` Kristian Evensen
2021-06-15 11:04 ` Kristian Evensen
2021-06-15 13:39 ` Bjørn Mork
2021-06-15 19:26 ` Jakub Kicinski
2021-06-15 19:27 ` Jakub Kicinski
2021-06-16 10:08 ` Kristian Evensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmwnwspk.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=kristian.evensen@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).