[PATCH] net: wan: wanxl: define CROSS_COMPILE_M68K

[PATCH] net: wan: wanxl: define CROSS_COMPILE_M68K

[Adam Borowski]

It was used but never set.  The hardcoded value from before the dawn of
time was non-standard; the usual name for cross-tools is $TRIPLET-$TOOL

Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
 This is neither the host nor target arch, thus it's very unlikely to be
 set by the user.  With this patch, it works out of the box on Debian
 and Fedora.

 drivers/net/wan/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wan/Makefile b/drivers/net/wan/Makefile
index f6b92efffc94..480bcd1f6c1c 100644
--- a/drivers/net/wan/Makefile
+++ b/drivers/net/wan/Makefile
@@ -34,6 +34,8 @@ obj-$(CONFIG_SLIC_DS26522)	+= slic_ds26522.o
 clean-files := wanxlfw.inc
 $(obj)/wanxl.o:	$(obj)/wanxlfw.inc
 
+CROSS_COMPILE_M68K = m68k-linux-gnu-
+
 ifeq ($(CONFIG_WANXL_BUILD_FIRMWARE),y)
 ifeq ($(ARCH),m68k)
   M68KCC = $(CC)
-- 
2.33.0

Re: [PATCH] net: wan: wanxl: define CROSS_COMPILE_M68K

[Randy Dunlap]

On 9/12/21 2:23 PM, Adam Borowski wrote:
> It was used but never set.  The hardcoded value from before the dawn of
> time was non-standard; the usual name for cross-tools is $TRIPLET-$TOOL
> 
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
>   This is neither the host nor target arch, thus it's very unlikely to be
>   set by the user.  With this patch, it works out of the box on Debian
>   and Fedora.
> 
>   drivers/net/wan/Makefile | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wan/Makefile b/drivers/net/wan/Makefile
> index f6b92efffc94..480bcd1f6c1c 100644
> --- a/drivers/net/wan/Makefile
> +++ b/drivers/net/wan/Makefile
> @@ -34,6 +34,8 @@ obj-$(CONFIG_SLIC_DS26522)	+= slic_ds26522.o
>   clean-files := wanxlfw.inc
>   $(obj)/wanxl.o:	$(obj)/wanxlfw.inc
>   
> +CROSS_COMPILE_M68K = m68k-linux-gnu-
> +
>   ifeq ($(CONFIG_WANXL_BUILD_FIRMWARE),y)
>   ifeq ($(ARCH),m68k)
>     M68KCC = $(CC)
> 

Just curious: why is all of that M68K/m68k stuff
even in this makefile?

thanks.
-- 
~Randy

Re: [PATCH] net: wan: wanxl: define CROSS_COMPILE_M68K

[Jakub Kicinski]

On Sun, 12 Sep 2021 23:23:21 +0200 Adam Borowski wrote:
> It was used but never set.  The hardcoded value from before the dawn of
> time was non-standard; the usual name for cross-tools is $TRIPLET-$TOOL
> 
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
>  This is neither the host nor target arch, thus it's very unlikely to be
>  set by the user.  With this patch, it works out of the box on Debian
>  and Fedora.
> 
>  drivers/net/wan/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wan/Makefile b/drivers/net/wan/Makefile
> index f6b92efffc94..480bcd1f6c1c 100644
> --- a/drivers/net/wan/Makefile
> +++ b/drivers/net/wan/Makefile
> @@ -34,6 +34,8 @@ obj-$(CONFIG_SLIC_DS26522)	+= slic_ds26522.o
>  clean-files := wanxlfw.inc
>  $(obj)/wanxl.o:	$(obj)/wanxlfw.inc
>  
> +CROSS_COMPILE_M68K = m68k-linux-gnu-

This will not overwrite the parameter if set from command line, right?
My Makefile-foo is getting rusty.

>  ifeq ($(CONFIG_WANXL_BUILD_FIRMWARE),y)
>  ifeq ($(ARCH),m68k)
>    M68KCC = $(CC)

Re: [PATCH] net: wan: wanxl: define CROSS_COMPILE_M68K

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sun, 12 Sep 2021 23:23:21 +0200 you wrote:
> It was used but never set.  The hardcoded value from before the dawn of
> time was non-standard; the usual name for cross-tools is $TRIPLET-$TOOL
> 
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
>  This is neither the host nor target arch, thus it's very unlikely to be
>  set by the user.  With this patch, it works out of the box on Debian
>  and Fedora.
> 
> [...]

Here is the summary with links:
  - net: wan: wanxl: define CROSS_COMPILE_M68K
    https://git.kernel.org/netdev/net/c/84fb7dfc7463

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html