netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Stephen Suryaputra <ssuryaextr@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] vrf: Increment Icmp6InMsgs on the original netdev
Date: Thu, 6 Jun 2019 10:25:35 -0600	[thread overview]
Message-ID: <892ec6a9-a85b-3d58-2598-b2aa169a3880@gmail.com> (raw)
In-Reply-To: <20190601181429.GB16560@ubuntu>

On 6/1/19 12:14 PM, Stephen Suryaputra wrote:
> On Fri, May 31, 2019 at 05:06:16PM -0600, David Ahern wrote:
>> On 5/29/19 11:08 PM, Stephen Suryaputra wrote:
>>> diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
>>> index 1a832f5e190b..9b365c345c34 100644
>>> --- a/net/ipv6/reassembly.c
>>> +++ b/net/ipv6/reassembly.c
>>> @@ -260,6 +260,9 @@ static int ip6_frag_reasm(struct frag_queue *fq, struct sk_buff *skb,
>>>  	int payload_len;
>>>  	u8 ecn;
>>>  
>>> +	if (netif_is_l3_master(dev))
>>> +		dev = dev_get_by_index_rcu(net, inet6_iif(skb));
>>> +
>>>  	inet_frag_kill(&fq->q);
>>>  
>>>  	ecn = ip_frag_ecn_table[fq->ecn];
>>>
>>
>> this part changes skb->dev. Seems like it has an unintended effect if
>> the packet is delivered locally.
> 
> Ah, right. How about this then?
> 

looks ok to me.

      reply	other threads:[~2019-06-06 16:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30  5:08 [PATCH net] vrf: Increment Icmp6InMsgs on the original netdev Stephen Suryaputra
2019-05-31 21:32 ` David Miller
2019-05-31 23:06 ` David Ahern
2019-06-01 18:14   ` Stephen Suryaputra
2019-06-06 16:25     ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=892ec6a9-a85b-3d58-2598-b2aa169a3880@gmail.com \
    --to=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ssuryaextr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).