netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: dsa: b53: relax is63xx() condition
@ 2021-03-08 18:08 Álvaro Fernández Rojas
  2021-03-08 18:25 ` Florian Fainelli
  0 siblings, 1 reply; 2+ messages in thread
From: Álvaro Fernández Rojas @ 2021-03-08 18:08 UTC (permalink / raw)
  To: jonas.gorski, Florian Fainelli, Andrew Lunn, Vivien Didelot,
	Vladimir Oltean, David S. Miller, Jakub Kicinski, netdev,
	linux-kernel
  Cc: Álvaro Fernández Rojas

BCM63xx switches are present on bcm63xx and bmips devices.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 drivers/net/dsa/b53/b53_priv.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/dsa/b53/b53_priv.h b/drivers/net/dsa/b53/b53_priv.h
index 8419bb7f4505..82700a5714c1 100644
--- a/drivers/net/dsa/b53/b53_priv.h
+++ b/drivers/net/dsa/b53/b53_priv.h
@@ -186,11 +186,7 @@ static inline int is531x5(struct b53_device *dev)
 
 static inline int is63xx(struct b53_device *dev)
 {
-#ifdef CONFIG_BCM63XX
 	return dev->chip_id == BCM63XX_DEVICE_ID;
-#else
-	return 0;
-#endif
 }
 
 static inline int is5301x(struct b53_device *dev)
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: dsa: b53: relax is63xx() condition
  2021-03-08 18:08 [PATCH] net: dsa: b53: relax is63xx() condition Álvaro Fernández Rojas
@ 2021-03-08 18:25 ` Florian Fainelli
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2021-03-08 18:25 UTC (permalink / raw)
  To: Álvaro Fernández Rojas, jonas.gorski, Andrew Lunn,
	Vivien Didelot, Vladimir Oltean, David S. Miller, Jakub Kicinski,
	netdev, linux-kernel

On 3/8/21 10:08 AM, Álvaro Fernández Rojas wrote:
> BCM63xx switches are present on bcm63xx and bmips devices.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Since you are targeting net-next, please make it clear in the patch
subject next time:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n28
-- 
Florian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-08 18:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 18:08 [PATCH] net: dsa: b53: relax is63xx() condition Álvaro Fernández Rojas
2021-03-08 18:25 ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).