From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Sasha Levin <sashal@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
stable@vger.kernel.org, linux-can@vger.kernel.org,
lifeasageek@gmail.com, threeearcat@gmail.com,
syzkaller@googlegroups.com, nautsch2@gmail.com,
Kyungtae Kim <kt0755@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH] [stable pre-4.8] can: bcm: check timer values before ktime conversion
Date: Sun, 27 Jan 2019 19:22:38 +0100 [thread overview]
Message-ID: <8a72ffa5-dac5-6de8-f01e-dfbb98b1f024@hartkopp.net> (raw)
In-Reply-To: <20190126181718.GE30183@sasha-vm>
Hi Sasha,
On 26.01.19 19:17, Sasha Levin wrote:
> On Thu, Jan 24, 2019 at 10:08:42AM +0100, Oliver Hartkopp wrote:
>> Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup()
>> when the conversion into ktime multiplies the given value with
>> NSEC_PER_USEC
>> (1000).
>>
>> Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2
>>
>> Add a check for the given tv_usec, so that the value stays below one
>> second.
>> Additionally limit the tv_sec value to a reasonable value for CAN related
>> use-cases of 400 days and ensure all values to be positive.
>>
>> This patch is the pre-4.8 version of upstream commit 93171ba6f1deffd8
>
> I can't find this commit id upstream, there's nothing with the same
> subject name, nor does this code exist upstream. What's going on?
Here we are (pulled by Linus some minutes ago):
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93171ba6f1deffd82f381d36cb13177872d023f6
Can you go with this pre-4.8 version now?
Many thanks,
Oliver
next prev parent reply other threads:[~2019-01-27 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 9:08 [PATCH] [stable pre-4.8] can: bcm: check timer values before ktime conversion Oliver Hartkopp
2019-01-26 18:17 ` Sasha Levin
2019-01-27 18:22 ` Oliver Hartkopp [this message]
2019-01-27 19:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a72ffa5-dac5-6de8-f01e-dfbb98b1f024@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=kt0755@gmail.com \
--cc=lifeasageek@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=nautsch2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=threeearcat@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).