* [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode'
@ 2018-10-19 12:40 YueHaibing
2018-10-24 10:20 ` Neftin, Sasha
2018-11-01 19:24 ` Brown, Aaron F
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-10-19 12:40 UTC (permalink / raw)
To: Jeff Kirsher, Sasha Neftin
Cc: YueHaibing, intel-wired-lan, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/intel/igc/igc_base.c: In function 'igc_init_phy_params_base':
drivers/net/ethernet/intel/igc/igc_base.c:240:6: warning:
variable 'ctrl_ext' set but not used [-Wunused-but-set-variable]
u32 ctrl_ext;
drivers/net/ethernet/intel/igc/igc_base.c: In function 'igc_get_invariants_base':
drivers/net/ethernet/intel/igc/igc_base.c:290:6: warning:
variable 'link_mode' set but not used [-Wunused-but-set-variable]
u32 link_mode = 0;
It never used since introduction in
commit c0071c7aa5fe ("igc: Add HW initialization code")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
I'm not sure that reading IGC_CTRL_EXT is necessary.
---
drivers/net/ethernet/intel/igc/igc_base.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_base.c b/drivers/net/ethernet/intel/igc/igc_base.c
index 832da609..df40af7 100644
--- a/drivers/net/ethernet/intel/igc/igc_base.c
+++ b/drivers/net/ethernet/intel/igc/igc_base.c
@@ -237,7 +237,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)
{
struct igc_phy_info *phy = &hw->phy;
s32 ret_val = 0;
- u32 ctrl_ext;
if (hw->phy.media_type != igc_media_type_copper) {
phy->type = igc_phy_none;
@@ -247,8 +246,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)
phy->autoneg_mask = AUTONEG_ADVERTISE_SPEED_DEFAULT_2500;
phy->reset_delay_us = 100;
- ctrl_ext = rd32(IGC_CTRL_EXT);
-
/* set lan id */
hw->bus.func = (rd32(IGC_STATUS) & IGC_STATUS_FUNC_MASK) >>
IGC_STATUS_FUNC_SHIFT;
@@ -287,8 +284,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)
static s32 igc_get_invariants_base(struct igc_hw *hw)
{
struct igc_mac_info *mac = &hw->mac;
- u32 link_mode = 0;
- u32 ctrl_ext = 0;
s32 ret_val = 0;
switch (hw->device_id) {
@@ -302,9 +297,6 @@ static s32 igc_get_invariants_base(struct igc_hw *hw)
hw->phy.media_type = igc_media_type_copper;
- ctrl_ext = rd32(IGC_CTRL_EXT);
- link_mode = ctrl_ext & IGC_CTRL_EXT_LINK_MODE_MASK;
-
/* mac initialization and operations */
ret_val = igc_init_mac_params_base(hw);
if (ret_val)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode'
2018-10-19 12:40 [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode' YueHaibing
@ 2018-10-24 10:20 ` Neftin, Sasha
2018-11-01 19:24 ` Brown, Aaron F
1 sibling, 0 replies; 3+ messages in thread
From: Neftin, Sasha @ 2018-10-24 10:20 UTC (permalink / raw)
To: YueHaibing, Jeff Kirsher
Cc: intel-wired-lan, netdev, kernel-janitors, Neftin, Sasha
On 10/19/2018 15:40, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/intel/igc/igc_base.c: In function 'igc_init_phy_params_base':
> drivers/net/ethernet/intel/igc/igc_base.c:240:6: warning:
> variable 'ctrl_ext' set but not used [-Wunused-but-set-variable]
> u32 ctrl_ext;
>
> drivers/net/ethernet/intel/igc/igc_base.c: In function 'igc_get_invariants_base':
> drivers/net/ethernet/intel/igc/igc_base.c:290:6: warning:
> variable 'link_mode' set but not used [-Wunused-but-set-variable]
> u32 link_mode = 0;
>
> It never used since introduction in
> commit c0071c7aa5fe ("igc: Add HW initialization code")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> I'm not sure that reading IGC_CTRL_EXT is necessary.
> ---
> drivers/net/ethernet/intel/igc/igc_base.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_base.c b/drivers/net/ethernet/intel/igc/igc_base.c
> index 832da609..df40af7 100644
> --- a/drivers/net/ethernet/intel/igc/igc_base.c
> +++ b/drivers/net/ethernet/intel/igc/igc_base.c
> @@ -237,7 +237,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)
> {
> struct igc_phy_info *phy = &hw->phy;
> s32 ret_val = 0;
> - u32 ctrl_ext;
>
> if (hw->phy.media_type != igc_media_type_copper) {
> phy->type = igc_phy_none;
> @@ -247,8 +246,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)
> phy->autoneg_mask = AUTONEG_ADVERTISE_SPEED_DEFAULT_2500;
> phy->reset_delay_us = 100;
>
> - ctrl_ext = rd32(IGC_CTRL_EXT);
> -
> /* set lan id */
> hw->bus.func = (rd32(IGC_STATUS) & IGC_STATUS_FUNC_MASK) >>
> IGC_STATUS_FUNC_SHIFT;
> @@ -287,8 +284,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)
> static s32 igc_get_invariants_base(struct igc_hw *hw)
> {
> struct igc_mac_info *mac = &hw->mac;
> - u32 link_mode = 0;
> - u32 ctrl_ext = 0;
> s32 ret_val = 0;
>
> switch (hw->device_id) {
> @@ -302,9 +297,6 @@ static s32 igc_get_invariants_base(struct igc_hw *hw)
>
> hw->phy.media_type = igc_media_type_copper;
>
> - ctrl_ext = rd32(IGC_CTRL_EXT);
> - link_mode = ctrl_ext & IGC_CTRL_EXT_LINK_MODE_MASK;
> -
> /* mac initialization and operations */
> ret_val = igc_init_mac_params_base(hw);
> if (ret_val)
>
Thanks for the patch. Good.
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode'
2018-10-19 12:40 [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode' YueHaibing
2018-10-24 10:20 ` Neftin, Sasha
@ 2018-11-01 19:24 ` Brown, Aaron F
1 sibling, 0 replies; 3+ messages in thread
From: Brown, Aaron F @ 2018-11-01 19:24 UTC (permalink / raw)
To: YueHaibing, Kirsher, Jeffrey T, Neftin, Sasha
Cc: intel-wired-lan, netdev, kernel-janitors
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of YueHaibing
> Sent: Friday, October 19, 2018 5:41 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; Neftin, Sasha
> <sasha.neftin@intel.com>
> Cc: YueHaibing <yuehaibing@huawei.com>; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext,
> link_mode'
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/intel/igc/igc_base.c: In function
> 'igc_init_phy_params_base':
> drivers/net/ethernet/intel/igc/igc_base.c:240:6: warning:
> variable 'ctrl_ext' set but not used [-Wunused-but-set-variable]
> u32 ctrl_ext;
>
> drivers/net/ethernet/intel/igc/igc_base.c: In function
> 'igc_get_invariants_base':
> drivers/net/ethernet/intel/igc/igc_base.c:290:6: warning:
> variable 'link_mode' set but not used [-Wunused-but-set-variable]
> u32 link_mode = 0;
>
> It never used since introduction in
> commit c0071c7aa5fe ("igc: Add HW initialization code")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> I'm not sure that reading IGC_CTRL_EXT is necessary.
> ---
> drivers/net/ethernet/intel/igc/igc_base.c | 8 --------
> 1 file changed, 8 deletions(-)
>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-02 4:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-19 12:40 [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode' YueHaibing
2018-10-24 10:20 ` Neftin, Sasha
2018-11-01 19:24 ` Brown, Aaron F
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).