* Re: [PATCH bpf-next v3 0/3] Add more bpf_*_ct_lookup() selftests
[not found] <cover.1660173222.git.dxu@dxuuu.xyz>
@ 2022-08-11 0:25 ` Kumar Kartikeya Dwivedi
2022-08-11 21:50 ` Daniel Xu
0 siblings, 1 reply; 2+ messages in thread
From: Kumar Kartikeya Dwivedi @ 2022-08-11 0:25 UTC (permalink / raw)
To: Daniel Xu
Cc: bpf, ast, daniel, andrii, linux-kernel, netdev, netfilter-devel,
pablo, fw, toke
On Thu, 11 Aug 2022 at 01:16, Daniel Xu <dxu@dxuuu.xyz> wrote:
>
> This patchset adds more bpf_*_ct_lookup() selftests. The goal is to test
> interaction with netfilter subsystem as well as reading from `struct
> nf_conn`. The first is important when migrating legacy systems towards
> bpf. The latter is important in general to take full advantage of
> connection tracking.
>
Thank you for contributing these tests. Feel free to add:
Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
People often look at selftests for usage examples these days, so it's
great to have coverage + examples for more use cases.
> I'll follow this patchset up with support for writing to `struct nf_conn`.
>
Please also cc netfilter-devel, netdev, Pablo, and Florian when you send it.
I think we can directly enable stores to ct->mark, since that is what
ctnetlink is doing too, so adding another helper for this would be
unnecessary overhead.
> Past discussion:
> - v2: https://lore.kernel.org/bpf/cover.1660062725.git.dxu@dxuuu.xyz/
> - v1: https://lore.kernel.org/bpf/cover.1659209738.git.dxu@dxuuu.xyz/
>
> Changes since v2:
> - Add bpf-ci kconfig changes
>
> Changes since v1:
> - Reword commit message / cover letter to not mention connmark writing
>
>
> Daniel Xu (3):
> selftests/bpf: Add existing connection bpf_*_ct_lookup() test
> selftests/bpf: Add connmark read test
> selftests/bpf: Update CI kconfig
>
> tools/testing/selftests/bpf/config | 2 +
> .../testing/selftests/bpf/prog_tests/bpf_nf.c | 60 +++++++++++++++++++
> .../testing/selftests/bpf/progs/test_bpf_nf.c | 21 +++++++
> 3 files changed, 83 insertions(+)
>
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next v3 0/3] Add more bpf_*_ct_lookup() selftests
2022-08-11 0:25 ` [PATCH bpf-next v3 0/3] Add more bpf_*_ct_lookup() selftests Kumar Kartikeya Dwivedi
@ 2022-08-11 21:50 ` Daniel Xu
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Xu @ 2022-08-11 21:50 UTC (permalink / raw)
To: Kumar Kartikeya Dwivedi
Cc: bpf, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
linux-kernel, netdev, netfilter-devel, pablo, fw, toke
Hi Kumar,
On Wed, Aug 10, 2022, at 6:25 PM, Kumar Kartikeya Dwivedi wrote:
> On Thu, 11 Aug 2022 at 01:16, Daniel Xu <dxu@dxuuu.xyz> wrote:
>>
>> This patchset adds more bpf_*_ct_lookup() selftests. The goal is to test
>> interaction with netfilter subsystem as well as reading from `struct
>> nf_conn`. The first is important when migrating legacy systems towards
>> bpf. The latter is important in general to take full advantage of
>> connection tracking.
>>
>
> Thank you for contributing these tests. Feel free to add:
> Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
>
> People often look at selftests for usage examples these days, so it's
> great to have coverage + examples for more use cases.
I also want this interaction to still work when I start using it later :).
>
>> I'll follow this patchset up with support for writing to `struct nf_conn`.
>>
>
> Please also cc netfilter-devel, netdev, Pablo, and Florian when you send it.
>
Ack.
> I think we can directly enable stores to ct->mark, since that is what
> ctnetlink is doing too, so adding another helper for this would be
> unnecessary overhead.
Ack.
[...]
Thanks,
Danel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-11 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1660173222.git.dxu@dxuuu.xyz>
2022-08-11 0:25 ` [PATCH bpf-next v3 0/3] Add more bpf_*_ct_lookup() selftests Kumar Kartikeya Dwivedi
2022-08-11 21:50 ` Daniel Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).