From: Joe Perches <joe@perches.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
"Daniel Borkmann" <borkmann@iogearbox.net>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Björn Töpel" <bjorn.topel@intel.com>
Subject: Re: [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries
Date: Thu, 19 Nov 2020 14:16:20 -0800 [thread overview]
Message-ID: <8eef085f2b4d565463d5251a4868c7aaa19bf6ab.camel@perches.com> (raw)
In-Reply-To: <20201119215012.57d39102@carbon>
On Thu, 2020-11-19 at 21:50 +0100, Jesper Dangaard Brouer wrote:
> On Thu, 19 Nov 2020 10:02:10 -0800
> Jakub Kicinski <kuba@kernel.org> wrote:
>
> > On Thu, 19 Nov 2020 18:26:40 +0100 Jesper Dangaard Brouer wrote:
> > > Getting too many false positive matches with current use
> > > of the content regex K: and file regex N: patterns.
> > >
> > > This patch drops file match N: and makes K: more restricted.
> > > Some more normal F: file wildcards are added.
> > >
> > > Notice that AF_XDP forgot to some F: files that is also
> > > updated in this patch.
> > >
> > > Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> >
> > Ah! Sorry, I missed that you sent this before replying to Joe.
> >
> > Would you mind respining with his regex?
>
> Sure, I just send it... with your adjusted '(\b|_)xdp(\b|_)' regex, as
> it seems to do the same thing (and it works with egrep).
The regexes in MAINTAINERS are perl not egrep and using (\b|_)
creates unnecessary capture groups.
It _really_ should be (?:\b|_)xdp(?:\b|_)
next prev parent reply other threads:[~2020-11-19 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 17:26 [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries Jesper Dangaard Brouer
2020-11-19 18:02 ` Jakub Kicinski
2020-11-19 20:50 ` Jesper Dangaard Brouer
2020-11-19 22:16 ` Joe Perches [this message]
2020-11-20 8:47 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eef085f2b4d565463d5251a4868c7aaa19bf6ab.camel@perches.com \
--to=joe@perches.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).