* [PATCH] iscsi: qedi (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes
@ 2020-07-13 21:15 Laurence Oberman
2020-07-14 0:58 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Laurence Oberman @ 2020-07-13 21:15 UTC (permalink / raw)
To: loberman, linux-scsi, QLogic-Storage-Upstream, netdev, aelior,
GR-everest-linux-l2
This is likely firmware causing this but its starting to annoy customers.
Change the message level to verbose to prevent the spam.
Signed-off-by: Laurence Oberman <loberman@redhat.com>
---
drivers/net/ethernet/qlogic/qed/qed_int.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
index b7b974f..d853eb9 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_int.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
@@ -1193,7 +1193,8 @@ static int qed_int_attentions(struct qed_hwfn *p_hwfn)
index, attn_bits, attn_acks, asserted_bits,
deasserted_bits, p_sb_attn_sw->known_attn);
} else if (asserted_bits == 0x100) {
- DP_INFO(p_hwfn, "MFW indication via attention\n");
+ DP_VERBOSE(p_hwfn, NETIF_MSG_INTR,
+ "MFW indication via attention\n");
} else {
DP_VERBOSE(p_hwfn, NETIF_MSG_INTR,
"MFW indication [deassertion]\n");
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iscsi: qedi (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes
2020-07-13 21:15 [PATCH] iscsi: qedi (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes Laurence Oberman
@ 2020-07-14 0:58 ` David Miller
2020-07-14 13:41 ` Laurence Oberman
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2020-07-14 0:58 UTC (permalink / raw)
To: loberman
Cc: linux-scsi, QLogic-Storage-Upstream, netdev, aelior, GR-everest-linux-l2
From: Laurence Oberman <loberman@redhat.com>
Date: Mon, 13 Jul 2020 17:15:41 -0400
> This is likely firmware causing this but its starting to annoy customers.
> Change the message level to verbose to prevent the spam.
>
> Signed-off-by: Laurence Oberman <loberman@redhat.com>
"iscsi:" doesn't belong in this Subject line.
Please look at recent changes to this driver and what commit header
line subsystem prefixes and layout is being used.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iscsi: qedi (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes
2020-07-14 0:58 ` David Miller
@ 2020-07-14 13:41 ` Laurence Oberman
0 siblings, 0 replies; 3+ messages in thread
From: Laurence Oberman @ 2020-07-14 13:41 UTC (permalink / raw)
To: David Miller
Cc: linux-scsi, QLogic-Storage-Upstream, netdev, aelior, GR-everest-linux-l2
On Mon, 2020-07-13 at 17:58 -0700, David Miller wrote:
> From: Laurence Oberman <loberman@redhat.com>
> Date: Mon, 13 Jul 2020 17:15:41 -0400
>
> > This is likely firmware causing this but its starting to annoy
> customers.
> > Change the message level to verbose to prevent the spam.
> >
> > Signed-off-by: Laurence Oberman <loberman@redhat.com>
>
> "iscsi:" doesn't belong in this Subject line.
>
> Please look at recent changes to this driver and what commit header
> line subsystem prefixes and layout is being used.
>
> Thanks.
>
Hi Dave, I will resend.
The challenge is that while the proposed fix is in qed_int.c it only
manifests when the ISCSI persinality is enabled on the card.
I will set as appropriate header but mention the qedi ISCSI connection
in the V2 of this patch.
Thanks
Laurence
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-14 13:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 21:15 [PATCH] iscsi: qedi (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes Laurence Oberman
2020-07-14 0:58 ` David Miller
2020-07-14 13:41 ` Laurence Oberman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).