netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check
@ 2020-02-02 11:02 Michal Rostecki
  2020-02-02 19:59 ` Yonghong Song
  2020-02-03 23:10 ` Daniel Borkmann
  0 siblings, 2 replies; 3+ messages in thread
From: Michal Rostecki @ 2020-02-02 11:02 UTC (permalink / raw)
  To: bpf
  Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
	Yonghong Song, Andrii Nakryiko, netdev, linux-kernel

"HAVE" prefix is already applied by default to feature macros and before
this change, the large INSN limit macro had the incorrect name with
double "HAVE".

Fixes: 2faef64aa6b3 ("bpftool: Add misc section and probe for large INSN limit")
Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
---
 tools/bpf/bpftool/feature.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
index 446ba891f1e2..941873d778d8 100644
--- a/tools/bpf/bpftool/feature.c
+++ b/tools/bpf/bpftool/feature.c
@@ -580,7 +580,7 @@ probe_large_insn_limit(const char *define_prefix, __u32 ifindex)
 	res = bpf_probe_large_insn_limit(ifindex);
 	print_bool_feature("have_large_insn_limit",
 			   "Large program size limit",
-			   "HAVE_LARGE_INSN_LIMIT",
+			   "LARGE_INSN_LIMIT",
 			   res, define_prefix);
 }
 
-- 
2.16.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check
  2020-02-02 11:02 [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check Michal Rostecki
@ 2020-02-02 19:59 ` Yonghong Song
  2020-02-03 23:10 ` Daniel Borkmann
  1 sibling, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2020-02-02 19:59 UTC (permalink / raw)
  To: Michal Rostecki, bpf
  Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
	Andrii Nakryiko, netdev, linux-kernel



On 2/2/20 3:02 AM, Michal Rostecki wrote:
> "HAVE" prefix is already applied by default to feature macros and before
> this change, the large INSN limit macro had the incorrect name with
> double "HAVE".
> 
> Fixes: 2faef64aa6b3 ("bpftool: Add misc section and probe for large INSN limit")
> Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>

Acked-by: Yonghong Song <yhs@fb.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check
  2020-02-02 11:02 [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check Michal Rostecki
  2020-02-02 19:59 ` Yonghong Song
@ 2020-02-03 23:10 ` Daniel Borkmann
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2020-02-03 23:10 UTC (permalink / raw)
  To: Michal Rostecki, bpf
  Cc: Alexei Starovoitov, Martin KaFai Lau, Song Liu, Yonghong Song,
	Andrii Nakryiko, netdev, linux-kernel

On 2/2/20 12:02 PM, Michal Rostecki wrote:
> "HAVE" prefix is already applied by default to feature macros and before
> this change, the large INSN limit macro had the incorrect name with
> double "HAVE".
> 
> Fixes: 2faef64aa6b3 ("bpftool: Add misc section and probe for large INSN limit")
> Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-03 23:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-02 11:02 [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check Michal Rostecki
2020-02-02 19:59 ` Yonghong Song
2020-02-03 23:10 ` Daniel Borkmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).