From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [PATCH 0/2] net: dsa: mv88e6xxx: fix vlan filtering for 6250
Date: Mon, 18 Jan 2021 14:22:57 +0100 [thread overview]
Message-ID: <97021b7f-d1d9-b33f-f6ef-de3df83c17e5@prevas.dk> (raw)
In-Reply-To: <20210117210858.276rk6svvqbfbfol@skbuf>
On 17/01/2021 22.08, Vladimir Oltean wrote:
> Hi Rasmus,
>
> On Sat, Jan 16, 2021 at 03:39:34AM +0100, Rasmus Villemoes wrote:
>> I finally managed to figure out why enabling VLAN filtering on the
>> 6250 broke all (ingressing) traffic,
>> cf. https://lore.kernel.org/netdev/6424c14e-bd25-2a06-cf0b-f1a07f9a3604@prevas.dk/
>> .
>>
>> The first patch is the minimal fix and for net, while the second one
>> is a little cleanup for net-next.
>>
>> Rasmus Villemoes (2):
>> net: dsa: mv88e6xxx: also read STU state in mv88e6250_g1_vtu_getnext
>> net: dsa: mv88e6xxx: use mv88e6185_g1_vtu_getnext() for the 6250
>
> It's strange to put a patch for net and one for net-next in the same
> series.
Well, maybe, but one is a logical continuation of the other, and
including the second one preempted review comments saying "why don't you
merge the two implementations".
> But is there any reason why you don't just apply the second patch to
> "net"?
That's not really for me to decide? I thought net was just for the
things that needed fixing and should be sent to -stable - which is the
only reason I even split this in two, so there's a minimal logical fix
for the 6250. Otherwise I'd just have squashed the two, so that I don't
add lines only to delete them, along with the rest of the function, later.
Jakub, David, it's up to you.
Rasmus
next prev parent reply other threads:[~2021-01-18 13:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 2:39 [PATCH 0/2] net: dsa: mv88e6xxx: fix vlan filtering for 6250 Rasmus Villemoes
2021-01-16 2:39 ` [PATCH net 1/2] net: dsa: mv88e6xxx: also read STU state in mv88e6250_g1_vtu_getnext Rasmus Villemoes
2021-01-16 5:01 ` Florian Fainelli
2021-01-16 12:20 ` Tobias Waldekranz
2021-01-16 2:39 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: use mv88e6185_g1_vtu_getnext() for the 6250 Rasmus Villemoes
2021-01-16 5:01 ` Florian Fainelli
2021-01-16 12:22 ` Tobias Waldekranz
2021-01-17 21:08 ` [PATCH 0/2] net: dsa: mv88e6xxx: fix vlan filtering for 6250 Vladimir Oltean
2021-01-18 13:22 ` Rasmus Villemoes [this message]
2021-01-18 21:08 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97021b7f-d1d9-b33f-f6ef-de3df83c17e5@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).