* [PATCH] isdn: hisax: hfc_usb: constify usb_device_id
@ 2017-08-08 16:49 Arvind Yadav
2017-08-08 16:49 ` [PATCH] isdn: hfcsusb: " Arvind Yadav
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-08 16:49 UTC (permalink / raw)
To: isdn; +Cc: linux-kernel, netdev
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hisax/hfc_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/hfc_usb.c b/drivers/isdn/hisax/hfc_usb.c
index ef47480..e821218 100644
--- a/drivers/isdn/hisax/hfc_usb.c
+++ b/drivers/isdn/hisax/hfc_usb.c
@@ -65,7 +65,7 @@ typedef struct {
} hfcsusb_vdata;
/* VID/PID device list */
-static struct usb_device_id hfcusb_idtab[] = {
+static const struct usb_device_id hfcusb_idtab[] = {
{
USB_DEVICE(0x0959, 0x2bd0),
.driver_info = (unsigned long) &((hfcsusb_vdata)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] isdn: hfcsusb: constify usb_device_id
2017-08-08 16:49 [PATCH] isdn: hisax: hfc_usb: constify usb_device_id Arvind Yadav
@ 2017-08-08 16:49 ` Arvind Yadav
0 siblings, 0 replies; 2+ messages in thread
From: Arvind Yadav @ 2017-08-08 16:49 UTC (permalink / raw)
To: isdn; +Cc: linux-kernel, netdev
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/isdn/hardware/mISDN/hfcsusb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.h b/drivers/isdn/hardware/mISDN/hfcsusb.h
index 4157311..5f8f1d9 100644
--- a/drivers/isdn/hardware/mISDN/hfcsusb.h
+++ b/drivers/isdn/hardware/mISDN/hfcsusb.h
@@ -337,7 +337,7 @@ static const char *HFC_NT_LAYER1_STATES[HFC_MAX_NT_LAYER1_STATE + 1] = {
};
/* supported devices */
-static struct usb_device_id hfcsusb_idtab[] = {
+static const struct usb_device_id hfcsusb_idtab[] = {
{
USB_DEVICE(0x0959, 0x2bd0),
.driver_info = (unsigned long) &((struct hfcsusb_vdata)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-08 16:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 16:49 [PATCH] isdn: hisax: hfc_usb: constify usb_device_id Arvind Yadav
2017-08-08 16:49 ` [PATCH] isdn: hfcsusb: " Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).