netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] can: flexcan: add support for DT property 'wakeup-source'
@ 2019-04-09  8:39 Sean Nyekjaer
  2019-04-09  8:39 ` [PATCH 2/2] dt-bindings: can: flexcan: add can wakeup property Sean Nyekjaer
  2019-06-08 17:36 ` [PATCH 1/2] can: flexcan: add support for DT property 'wakeup-source' Sean Nyekjaer
  0 siblings, 2 replies; 5+ messages in thread
From: Sean Nyekjaer @ 2019-04-09  8:39 UTC (permalink / raw)
  To: netdev, linux-can, mkl, robh+dt; +Cc: Sean Nyekjaer, devicetree

The flexcan controller can be forced as a wakeup source by
stating that explicitly in the device's .dts file using the
"wakeup-source" boolean property.

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 drivers/net/can/flexcan.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index c46e6ce22701..df3d2abd98e4 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -1373,6 +1373,9 @@ static int flexcan_setup_stop_mode(struct platform_device *pdev)
 
 	device_set_wakeup_capable(&pdev->dev, true);
 
+	if (of_property_read_bool(np, "wakeup-source"))
+		device_set_wakeup_enable(&pdev->dev, true);
+
 	return 0;
 }
 
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] dt-bindings: can: flexcan: add can wakeup property
  2019-04-09  8:39 [PATCH 1/2] can: flexcan: add support for DT property 'wakeup-source' Sean Nyekjaer
@ 2019-04-09  8:39 ` Sean Nyekjaer
  2019-04-29 17:39   ` Rob Herring
  2019-06-08 17:36 ` [PATCH 1/2] can: flexcan: add support for DT property 'wakeup-source' Sean Nyekjaer
  1 sibling, 1 reply; 5+ messages in thread
From: Sean Nyekjaer @ 2019-04-09  8:39 UTC (permalink / raw)
  To: netdev, linux-can, mkl, robh+dt; +Cc: Sean Nyekjaer, devicetree

add wakeup-source boolean property.

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
index bc77477c6878..17453be840d8 100644
--- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
+++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
@@ -32,6 +32,8 @@ Optional properties:
 		 ack_gpr is the gpr register offset of CAN stop acknowledge.
 		 ack_bit is the bit offset of CAN stop acknowledge.
 
+- wakeup-source: enable CAN remote wakeup
+
 Example:
 
 	can@1c000 {
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] dt-bindings: can: flexcan: add can wakeup property
  2019-04-09  8:39 ` [PATCH 2/2] dt-bindings: can: flexcan: add can wakeup property Sean Nyekjaer
@ 2019-04-29 17:39   ` Rob Herring
  2019-08-20  9:10     ` Sean Nyekjaer
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2019-04-29 17:39 UTC (permalink / raw)
  To: Sean Nyekjaer; +Cc: netdev, linux-can, mkl, robh+dt, Sean Nyekjaer, devicetree

On Tue,  9 Apr 2019 10:39:49 +0200, Sean Nyekjaer wrote:
> add wakeup-source boolean property.
> 
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
>  Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] can: flexcan: add support for DT property 'wakeup-source'
  2019-04-09  8:39 [PATCH 1/2] can: flexcan: add support for DT property 'wakeup-source' Sean Nyekjaer
  2019-04-09  8:39 ` [PATCH 2/2] dt-bindings: can: flexcan: add can wakeup property Sean Nyekjaer
@ 2019-06-08 17:36 ` Sean Nyekjaer
  1 sibling, 0 replies; 5+ messages in thread
From: Sean Nyekjaer @ 2019-06-08 17:36 UTC (permalink / raw)
  To: netdev, linux-can, mkl, robh+dt; +Cc: devicetree, aisheng.dong, qiangqing.zhang

kind ping :-)

On 09/04/2019 10.39, Sean Nyekjaer wrote:
> The flexcan controller can be forced as a wakeup source by
> stating that explicitly in the device's .dts file using the
> "wakeup-source" boolean property.
> 
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
>   drivers/net/can/flexcan.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index c46e6ce22701..df3d2abd98e4 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -1373,6 +1373,9 @@ static int flexcan_setup_stop_mode(struct platform_device *pdev)
>   
>   	device_set_wakeup_capable(&pdev->dev, true);
>   
> +	if (of_property_read_bool(np, "wakeup-source"))
> +		device_set_wakeup_enable(&pdev->dev, true);
> +
>   	return 0;
>   }
>   
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] dt-bindings: can: flexcan: add can wakeup property
  2019-04-29 17:39   ` Rob Herring
@ 2019-08-20  9:10     ` Sean Nyekjaer
  0 siblings, 0 replies; 5+ messages in thread
From: Sean Nyekjaer @ 2019-08-20  9:10 UTC (permalink / raw)
  To: linux-can, mkl; +Cc: Rob Herring, netdev, robh+dt, devicetree



On 29/04/2019 19.39, Rob Herring wrote:
> On Tue,  9 Apr 2019 10:39:49 +0200, Sean Nyekjaer wrote:
>> add wakeup-source boolean property.
>>
>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
>> ---
>>   Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 2 ++
>>   1 file changed, 2 insertions(+)
>>
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
>
This doesn't seem to be applied. PATCH 1/2 in this series is applied.

In any case which repo does this patch belong to?

/Sean

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-08-20  9:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09  8:39 [PATCH 1/2] can: flexcan: add support for DT property 'wakeup-source' Sean Nyekjaer
2019-04-09  8:39 ` [PATCH 2/2] dt-bindings: can: flexcan: add can wakeup property Sean Nyekjaer
2019-04-29 17:39   ` Rob Herring
2019-08-20  9:10     ` Sean Nyekjaer
2019-06-08 17:36 ` [PATCH 1/2] can: flexcan: add support for DT property 'wakeup-source' Sean Nyekjaer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).