From: Josh Elsasser <jelsasser@appneta.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>
Cc: Thomas Graf <tgraf@suug.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Josh Elsasser <jelsasser@appneta.com>
Subject: Re: [v2 PATCH] rhashtable: Still do rehash when we get EEXIST
Date: Sat, 26 Jan 2019 14:02:48 -0800 [thread overview]
Message-ID: <A247F887-832E-44AD-AC41-C22E124E44EE@appneta.com> (raw)
In-Reply-To: <D5A6C2E7-2AB1-46D0-8876-2D6AAAA3937F@appneta.com>
On Jan 23, 2019, at 7:40 PM, Josh Elsasser <jelsasser@appneta.com> wrote:
> On Jan 23, 2019, at 7:08 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
>> Thanks for catching this!
>>
>> Although I think we should fix this in a different way. The problem
>> here is that the shrink cannot proceed because there was a previous
>> rehash that is still incomplete. We should wait for its completion
>> and then reattempt a shrinnk should it still be necessary.
>
> I can't test this right now because our VM server's down
Got one of the poor little reproducer VM's back up and running and loaded
up this patch. Works like a charm. For the v2 PATCH, can add my:
Tested-by: Josh Elsasser <jelsasser@appneta.com>
next prev parent reply other threads:[~2019-01-26 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 21:17 [PATCH net] rhashtable: avoid reschedule loop after rapid growth and shrink Josh Elsasser
2019-01-24 3:08 ` [v2 PATCH] rhashtable: Still do rehash when we get EEXIST Herbert Xu
2019-01-24 3:40 ` Josh Elsasser
2019-01-26 22:02 ` Josh Elsasser [this message]
2019-03-20 22:39 ` Josh Hunt
[not found] ` <CAKA=qzY4Pzee9BVzRCciW32toeHSz7t0q9LuvQXKLG2fX9fBbg@mail.gmail.com>
2019-03-21 1:39 ` [v3 " Herbert Xu
2019-03-21 1:46 ` Herbert Xu
2019-03-21 20:58 ` David Miller
2019-03-21 20:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A247F887-832E-44AD-AC41-C22E124E44EE@appneta.com \
--to=jelsasser@appneta.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).