netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Hunt <joshhunt00@gmail.com>
To: Josh Elsasser <jelsasser@appneta.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	Thomas Graf <tgraf@suug.ch>, netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v2 PATCH] rhashtable: Still do rehash when we get EEXIST
Date: Wed, 20 Mar 2019 15:39:15 -0700	[thread overview]
Message-ID: <CAKA=qzZ96KQKFG+aXSws8S8fGGumUg9ReRNfOPVcK=fy9eornw@mail.gmail.com> (raw)
In-Reply-To: <A247F887-832E-44AD-AC41-C22E124E44EE@appneta.com>

On Sat, Jan 26, 2019 at 2:03 PM Josh Elsasser <jelsasser@appneta.com> wrote:
>
> On Jan 23, 2019, at 7:40 PM, Josh Elsasser <jelsasser@appneta.com> wrote:
> > On Jan 23, 2019, at 7:08 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> >> Thanks for catching this!
> >>
> >> Although I think we should fix this in a different way.  The problem
> >> here is that the shrink cannot proceed because there was a previous
> >> rehash that is still incomplete.  We should wait for its completion
> >> and then reattempt a shrinnk should it still be necessary.
> >
> > I can't test this right now because our VM server's down
>
> Got one of the poor little reproducer VM's back up and running and loaded
> up this patch. Works like a charm. For the v2 PATCH, can add my:
>
> Tested-by: Josh Elsasser <jelsasser@appneta.com>

Trying again... gmail sent HTML mail first time.

Herbert

We're seeing this pretty regularly on 4.14 LTS kernels. I didn't see
your change in any of the regular trees. Are there plans to submit
this? If so, can it get queued up for 4.14 stable too?

Thanks!
-- 
Josh

  reply	other threads:[~2019-03-20 22:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 21:17 [PATCH net] rhashtable: avoid reschedule loop after rapid growth and shrink Josh Elsasser
2019-01-24  3:08 ` [v2 PATCH] rhashtable: Still do rehash when we get EEXIST Herbert Xu
2019-01-24  3:40   ` Josh Elsasser
2019-01-26 22:02     ` Josh Elsasser
2019-03-20 22:39       ` Josh Hunt [this message]
     [not found]       ` <CAKA=qzY4Pzee9BVzRCciW32toeHSz7t0q9LuvQXKLG2fX9fBbg@mail.gmail.com>
2019-03-21  1:39         ` [v3 " Herbert Xu
2019-03-21  1:46           ` Herbert Xu
2019-03-21 20:58             ` David Miller
2019-03-21 20:58           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKA=qzZ96KQKFG+aXSws8S8fGGumUg9ReRNfOPVcK=fy9eornw@mail.gmail.com' \
    --to=joshhunt00@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jelsasser@appneta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).