From: "David Laight" <David.Laight@ACULAB.COM>
To: "Wolfgang Grandegger" <wg@grandegger.com>, <info@essax.com>
Cc: "Oliver Hartkopp" <socketcan@hartkopp.net>,
<netdev@vger.kernel.org>, <linux-can@vger.kernel.org>,
<socketcan-users@lists.berlios.de>, "IreneV" <boir1@yandex.ru>,
"Stanislav Yelenskiy" <stanislavelensky@yahoo.com>
Subject: RE: [PATCH net-next v2 2/4] can: cc770: add legacy ISA bus driver for the CC770 and AN82527
Date: Thu, 5 Jan 2012 12:00:37 -0000 [thread overview]
Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6D8AF31@saturn3.aculab.com> (raw)
In-Reply-To: <4F058ED5.2000407@grandegger.com>
> >>> - outb(reg, base);
> >>> - outb(val, base + 1);
> >>> + outw( reg + ( val<< 8), base);
> >>
> >> That modification does fix your problem, right? The others above
don't
> >> help nor harm but we don't know if it's really realted to the same
> >> problem. I wll dig a bit deeper.
> >
> > Exactly. The others above I removed because facing the opposite,
even
> > missing interrupts but then just to avoid other possible side
effects
> > and then assuming that they might be related.
>
> OK. My concern: Can we be sure that 16bit accesses are always
supported
> by the hardware? Does a spinlock_irqsave/spinlock_irqrestore around
the
> 8bit accesses already help?
Hmmm... are there any register reads that need the
same 'double cycle' sequence ??
If so you need to stop reads being interleaved (with
themselves and writes) so requesting a 16bit access
doesn't help.
Which means you need a spinlock...
David
next prev parent reply other threads:[~2012-01-05 12:00 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 9:43 [PATCH net-next v2 0/4] can: cc770: add support for the Bosch CC770 and Intel AN82527 Wolfgang Grandegger
2011-11-25 9:43 ` [PATCH net-next v2 1/4] can: cc770: add driver core " Wolfgang Grandegger
[not found] ` <1322214204-1121-2-git-send-email-wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-11-26 15:11 ` Oliver Hartkopp
2011-11-28 11:28 ` [Socketcan-users] " Marc Kleine-Budde
2011-11-28 13:52 ` Wolfgang Grandegger
[not found] ` <4ED3922A.50704-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-11-28 14:01 ` Marc Kleine-Budde
2011-11-28 14:01 ` [Socketcan-users] " David Laight
[not found] ` <4ED3941D.3070302-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-11-28 14:10 ` Wolfgang Grandegger
[not found] ` <4ED3966E.7080609-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-11-28 14:18 ` Marc Kleine-Budde
[not found] ` <4ED3704D.5020903-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-11-29 9:20 ` Wolfgang Grandegger
2011-11-25 9:43 ` [PATCH net-next v2 2/4] can: cc770: add legacy ISA bus driver for the CC770 and AN82527 Wolfgang Grandegger
[not found] ` <1322214204-1121-3-git-send-email-wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-11-26 14:59 ` Oliver Hartkopp
2011-11-28 8:56 ` Wolfgang Zarre
2011-11-28 9:17 ` Wolfgang Grandegger
2011-11-28 12:03 ` Wolfgang Zarre
[not found] ` <4ED37885.8080909-PyqsHJVlJN8AvxtiuMwx3w@public.gmane.org>
2011-11-28 16:06 ` Oliver Hartkopp
[not found] ` <4ED3B198.2040308-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2011-11-29 9:16 ` Wolfgang Grandegger
[not found] ` <4ED4A2EC.40103-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-12-04 18:47 ` Wolfgang Zarre
2011-12-04 18:56 ` Wolfgang Grandegger
[not found] ` <4EDBC25D.50405-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-12-06 21:08 ` Wolfgang Zarre
[not found] ` <4EDE8435.5080100-PyqsHJVlJN8AvxtiuMwx3w@public.gmane.org>
2011-12-07 13:42 ` Wolfgang Grandegger
2011-12-09 10:26 ` Wolfgang Grandegger
2011-12-11 18:33 ` Wolfgang Zarre
[not found] ` <4EE4F76E.3000506-PyqsHJVlJN8AvxtiuMwx3w@public.gmane.org>
2011-12-12 9:23 ` Wolfgang Grandegger
[not found] ` <4EE5C824.2050704-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-12-12 11:18 ` Wolfgang Zarre
2011-12-12 11:55 ` Wolfgang Grandegger
[not found] ` <4EE5EBBF.6080007-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-12-21 18:32 ` Wolfgang Zarre
2011-12-22 9:37 ` Wolfgang Grandegger
[not found] ` <4EF2FA3F.3010308-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-12-22 13:20 ` Wolfgang Zarre
[not found] ` <4EF32E84.1080006-PyqsHJVlJN8AvxtiuMwx3w@public.gmane.org>
2011-12-31 9:39 ` Wolfgang Zarre
2012-01-04 13:10 ` Wolfgang Grandegger
2012-01-05 3:29 ` Wolfgang Zarre
[not found] ` <4F051927.8010600-PyqsHJVlJN8AvxtiuMwx3w@public.gmane.org>
2012-01-05 11:51 ` Wolfgang Grandegger
2012-01-05 12:00 ` David Laight [this message]
2012-01-09 21:47 ` Wolfgang Zarre
2012-01-09 23:11 ` Marc Kleine-Budde
2012-01-10 9:30 ` Wolfgang Grandegger
2012-01-10 12:30 ` Wolfgang Zarre
2012-01-10 14:20 ` Wolfgang Grandegger
2012-01-10 14:25 ` Wolfgang Grandegger
2012-01-11 9:00 ` Wolfgang Zarre
2012-01-11 9:37 ` David Laight
2012-01-11 14:37 ` Wolfgang Zarre
2012-01-11 9:38 ` Marc Kleine-Budde
2012-01-11 14:42 ` Wolfgang Zarre
2012-01-11 15:02 ` Marc Kleine-Budde
2012-01-10 10:00 ` David Laight
2012-01-10 12:41 ` Wolfgang Zarre
2012-01-10 14:43 ` Wolfgang Grandegger
2012-01-10 14:50 ` Oliver Hartkopp
2012-01-10 16:13 ` Wolfgang Zarre
2012-01-10 16:20 ` Marc Kleine-Budde
2012-01-10 16:23 ` Wolfgang Grandegger
2012-01-10 19:02 ` Wolfgang Zarre
2012-01-11 9:05 ` Wolfgang Zarre
2012-01-11 9:31 ` Marc Kleine-Budde
2012-01-10 11:41 ` Henrik Maier
2012-01-10 11:59 ` Wolfgang Grandegger
2012-01-10 12:43 ` Wolfgang Zarre
2011-11-28 12:09 ` Marc Kleine-Budde
[not found] ` <4ED379F3.1070206-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-11-28 13:59 ` Wolfgang Grandegger
2011-11-28 14:03 ` David Laight
[not found] ` <AE90C24D6B3A694183C094C60CF0A2F6D8AEE9-CgBM+Bx2aUAnGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2011-11-28 14:09 ` Marc Kleine-Budde
[not found] ` <4ED3960F.4040508-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-11-28 15:10 ` Wolfgang Grandegger
2011-11-25 9:43 ` [PATCH net-next v2 3/4] can: cc770: add platform " Wolfgang Grandegger
2011-11-25 9:43 ` [PATCH net-next v2 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AE90C24D6B3A694183C094C60CF0A2F6D8AF31@saturn3.aculab.com \
--to=david.laight@aculab.com \
--cc=boir1@yandex.ru \
--cc=info@essax.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan-users@lists.berlios.de \
--cc=socketcan@hartkopp.net \
--cc=stanislavelensky@yahoo.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).