From: Jose Abreu <Jose.Abreu@synopsys.com>
To: David Miller <davem@davemloft.net>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"bbiswas@nvidia.com" <bbiswas@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: RE: [PATCH v3 0/2] net: stmmac: Enhanced addressing mode for DWMAC 4.10
Date: Wed, 25 Sep 2019 10:44:53 +0000 [thread overview]
Message-ID: <BN8PR12MB3266F851B071629898BB775AD3870@BN8PR12MB3266.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190924.214508.1949579574079200671.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sep/24/2019, 20:45:08 (UTC+00:00)
> From: Thierry Reding <thierry.reding@gmail.com>
> Date: Fri, 20 Sep 2019 19:00:34 +0200
>
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The DWMAC 4.10 supports the same enhanced addressing mode as later
> > generations. Parse this capability from the hardware feature registers
> > and set the EAME (Enhanced Addressing Mode Enable) bit when necessary.
>
> This looks like an enhancement and/or optimization rather than a bug fix.
Agree.
> Also, you're now writing to the high 32-bits unconditionally, even when
> it will always be zero because of 32-bit addressing. That looks like
> a step backwards to me.
Don't agree. As per previous discussions and as per my IP knowledge, if
EAME is not enabled / not supported the register can still be written.
This is not fast path and will not impact any remaining operation. Can
you please explain what exactly is the concern about this ?
Anyway, this is an important feature for performance so I hope Thierry
re-submits this once -next opens and addressing the review comments.
---
Thanks,
Jose Miguel Abreu
next prev parent reply other threads:[~2019-09-25 10:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 17:00 [PATCH v3 0/2] net: stmmac: Enhanced addressing mode for DWMAC 4.10 Thierry Reding
2019-09-20 17:00 ` [PATCH v3 1/2] net: stmmac: Only enable enhanced addressing mode when needed Thierry Reding
2019-09-20 17:00 ` [PATCH v3 2/2] net: stmmac: Support enhanced addressing mode for DWMAC 4.10 Thierry Reding
2019-09-20 17:02 ` [PATCH v3 0/2] net: stmmac: Enhanced " Florian Fainelli
2019-09-21 1:35 ` Thierry Reding
2019-09-24 19:45 ` David Miller
2019-09-25 10:44 ` Jose Abreu [this message]
2019-09-25 11:33 ` David Miller
2019-09-25 11:41 ` Jose Abreu
2019-09-25 11:46 ` Jose Abreu
2019-09-25 17:31 ` Florian Fainelli
2019-09-25 22:46 ` Thierry Reding
2019-09-26 8:22 ` Jose Abreu
2019-09-25 12:01 ` David Miller
2019-09-25 11:17 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB3266F851B071629898BB775AD3870@BN8PR12MB3266.namprd12.prod.outlook.com \
--to=jose.abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=bbiswas@nvidia.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).