From: Parav Pandit <parav@nvidia.com>
To: Randy Dunlap <rdunlap@infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: "jacob.e.keller@intel.com" <jacob.e.keller@intel.com>,
Jiri Pirko <jiri@nvidia.com>
Subject: RE: [PATCH net-next v5] devlink: Add devlink port documentation
Date: Tue, 8 Dec 2020 06:51:37 +0000 [thread overview]
Message-ID: <BY5PR12MB432225162ECED10369E209F6DCCD0@BY5PR12MB4322.namprd12.prod.outlook.com> (raw)
In-Reply-To: <02fd2fa9-f93e-a60b-6fc3-f309495ccf99@infradead.org>
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Tuesday, December 8, 2020 6:45 AM
>
> Hi--
>
> On 12/7/20 2:13 PM, Parav Pandit wrote:
> > Added documentation for devlink port and port function related
> commands.
> >
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> > ---
> > Changelog:
> > v4->v5:
> > - described logically ingress and egress point of devlink port
> > - removed networking from devlink port description
> > - rephrased port type description
> > - introdue PCI controller section and description
>
> introduce
>
> > - rephrased controller, device, function description
> > - removed confusing eswitch to system wording
> > - rephrased port function description
> > - added example of mac address in port function attribute description
>
> > ---
> > .../networking/devlink/devlink-port.rst | 116 ++++++++++++++++++
> > Documentation/networking/devlink/index.rst | 1 +
> > 2 files changed, 117 insertions(+)
> > create mode 100644 Documentation/networking/devlink/devlink-port.rst
> >
> > diff --git a/Documentation/networking/devlink/devlink-port.rst
> > b/Documentation/networking/devlink/devlink-port.rst
> > new file mode 100644
> > index 000000000000..dce87d2c07ac
> > --- /dev/null
> > +++ b/Documentation/networking/devlink/devlink-port.rst
> > @@ -0,0 +1,116 @@
> > +.. SPDX-License-Identifier: GPL-2.0
> > +
> > +============
> > +Devlink Port
> > +============
> > +
> > +``devlink-port`` is a port that exists on the device. It has a
> > +logically separate ingress/egress point of the device. A devlink port
> > +can be of one
>
> port can be any one
> of many flavours.
>
> > +among many flavours. A devlink port flavour along with port
> > +attributes describe what a port represents.
> > +
> > +A device driver that intends to publish a devlink port sets the
> > +devlink port attributes and registers the devlink port.
> > +
> > +Devlink port flavours are described below.
> > +
> > +.. list-table:: List of devlink port flavours
> > + :widths: 33 90
> > +
> > + * - Flavour
> > + - Description
> > + * - ``DEVLINK_PORT_FLAVOUR_PHYSICAL``
> > + - Any kind of physical networking port. This can be an eswitch physical
> > + port or any other physical port on the device.
> > + * - ``DEVLINK_PORT_FLAVOUR_DSA``
> > + - This indicates a DSA interconnect port.
> > + * - ``DEVLINK_PORT_FLAVOUR_CPU``
> > + - This indicates a CPU port applicable only to DSA.
> > + * - ``DEVLINK_PORT_FLAVOUR_PCI_PF``
> > + - This indicates an eswitch port representing a networking port of
> > + PCI physical function (PF).
I forgot to remove 'networking' from the networking port here.
Will include this fix this in v6 in Saeed's subfunction patchset along with addressing Randy's comments.
prev parent reply other threads:[~2020-12-08 6:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 16:41 [PATCH net-next] devlink: Add devlink port documentation Parav Pandit
2020-11-30 19:29 ` Jacob Keller
2020-11-30 19:51 ` Parav Pandit
2020-11-30 20:00 ` [PATCH net-next v2] " Parav Pandit
2020-11-30 20:27 ` Keller, Jacob E
2020-12-02 1:34 ` Jakub Kicinski
2020-12-02 4:27 ` Parav Pandit
2020-12-02 13:53 ` [PATCH net-next v3] " Parav Pandit
2020-12-03 2:27 ` Randy Dunlap
2020-12-03 5:06 ` Parav Pandit
2020-12-03 18:02 ` [PATCH net-next v4] " Parav Pandit
2020-12-03 20:31 ` Randy Dunlap
2020-12-05 20:27 ` Jakub Kicinski
2020-12-07 4:46 ` Parav Pandit
2020-12-07 17:40 ` Jakub Kicinski
2020-12-07 20:00 ` Parav Pandit
2020-12-07 20:12 ` Jakub Kicinski
2020-12-07 20:16 ` Parav Pandit
2020-12-07 22:13 ` [PATCH net-next v5] " Parav Pandit
2020-12-08 1:14 ` Randy Dunlap
2020-12-08 5:59 ` Parav Pandit
2020-12-08 6:51 ` Parav Pandit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB432225162ECED10369E209F6DCCD0@BY5PR12MB4322.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).