From: Randy Dunlap <rdunlap@infradead.org>
To: Parav Pandit <parav@nvidia.com>,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org
Cc: jacob.e.keller@intel.com, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next v4] devlink: Add devlink port documentation
Date: Thu, 3 Dec 2020 12:31:21 -0800 [thread overview]
Message-ID: <b15782d6-8156-5468-4b05-cdc5246d789b@infradead.org> (raw)
In-Reply-To: <20201203180255.5253-1-parav@nvidia.com>
Hi--
On 12/3/20 10:02 AM, Parav Pandit wrote:
> Added documentation for devlink port and port function related commands.
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> Changelog:
> v3->v4:
> - changed 'exist' to 'exists'
> - added 'an' eswitch
> - changed 'can have one' to 'consists of'
> - changed 'who intents' to 'that intends'
> - removed unnecessary comma
> - rewrote description for the example diagram
> - changed 'controller consist of' to 'controller consists of'
> v2->v3:
> - rephrased many lines
> - first paragraph now describe devlink port
> - instead of saying PCI device/function, using PCI function every
> where
> - changed 'physical link layer' to 'link layer'
> - made devlink port type description more clear
> - made devlink port flavour description more clear
> - moved devlink port type table after port flavour
> - added description for the example diagram
> - describe CPU port that its linked to DSA
> - made devlink port description for eswitch port more clear
> v1->v2:
> - Removed duplicate table entries for DEVLINK_PORT_FLAVOUR_VIRTUAL.
> - replaced 'consist of' to 'consisting'
> - changed 'can be' to 'can be of'
> ---
> .../networking/devlink/devlink-port.rst | 111 ++++++++++++++++++
> Documentation/networking/devlink/index.rst | 1 +
> 2 files changed, 112 insertions(+)
> create mode 100644 Documentation/networking/devlink/devlink-port.rst
>
> diff --git a/Documentation/networking/devlink/devlink-port.rst b/Documentation/networking/devlink/devlink-port.rst
> new file mode 100644
> index 000000000000..ac18cb8041dc
> --- /dev/null
> +++ b/Documentation/networking/devlink/devlink-port.rst
> @@ -0,0 +1,111 @@
I find that this doc is now readable. :)
Other people can comment on the technical details.
thanks.
--
~Randy
Acked-by: Randy Dunlap <rdunlap@infradead.org>
next prev parent reply other threads:[~2020-12-03 20:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 16:41 [PATCH net-next] devlink: Add devlink port documentation Parav Pandit
2020-11-30 19:29 ` Jacob Keller
2020-11-30 19:51 ` Parav Pandit
2020-11-30 20:00 ` [PATCH net-next v2] " Parav Pandit
2020-11-30 20:27 ` Keller, Jacob E
2020-12-02 1:34 ` Jakub Kicinski
2020-12-02 4:27 ` Parav Pandit
2020-12-02 13:53 ` [PATCH net-next v3] " Parav Pandit
2020-12-03 2:27 ` Randy Dunlap
2020-12-03 5:06 ` Parav Pandit
2020-12-03 18:02 ` [PATCH net-next v4] " Parav Pandit
2020-12-03 20:31 ` Randy Dunlap [this message]
2020-12-05 20:27 ` Jakub Kicinski
2020-12-07 4:46 ` Parav Pandit
2020-12-07 17:40 ` Jakub Kicinski
2020-12-07 20:00 ` Parav Pandit
2020-12-07 20:12 ` Jakub Kicinski
2020-12-07 20:16 ` Parav Pandit
2020-12-07 22:13 ` [PATCH net-next v5] " Parav Pandit
2020-12-08 1:14 ` Randy Dunlap
2020-12-08 5:59 ` Parav Pandit
2020-12-08 6:51 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b15782d6-8156-5468-4b05-cdc5246d789b@infradead.org \
--to=rdunlap@infradead.org \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).