RE: [PATCH 06/15] liquidio: use new module_firmware_crashed()

RE: [PATCH 06/15] liquidio: use new module_firmware_crashed()

[Derek Chickles]

> From: Luis Chamberlain <mcgrof@kernel.org>
> Sent: Friday, May 8, 2020 9:36 PM
> To: jeyu@kernel.org
> Cc: akpm@linux-foundation.org; arnd@arndb.de; rostedt@goodmis.org;
> mingo@redhat.com; aquini@redhat.com; cai@lca.pw; dyoung@redhat.com;
> bhe@redhat.com; peterz@infradead.org; tglx@linutronix.de;
> gpiccoli@canonical.com; pmladek@suse.com; tiwai@suse.de;
> schlad@suse.de; andriy.shevchenko@linux.intel.com;
> keescook@chromium.org; daniel.vetter@ffwll.ch; will@kernel.org;
> mchehab+samsung@kernel.org; kvalo@codeaurora.org;
> davem@davemloft.net; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Luis Chamberlain <mcgrof@kernel.org>; Derek
> Chickles <dchickles@marvell.com>; Satananda Burla <sburla@marvell.com>;
> Felix Manlunas <fmanlunas@marvell.com>
> Subject: [PATCH 06/15] liquidio: use new module_firmware_crashed()
> 
> ----------------------------------------------------------------------
> This makes use of the new module_firmware_crashed() to help annotate
> when firmware for device drivers crash. When firmware crashes devices can
> sometimes become unresponsive, and recovery sometimes requires a driver
> unload / reload and in the worst cases a reboot.
> 
> Using a taint flag allows us to annotate when this happens clearly.
> 
> Cc: Derek Chickles <dchickles@marvell.com>
> Cc: Satanand Burla <sburla@marvell.com>
> Cc: Felix Manlunas <fmanlunas@marvell.com>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c
> b/drivers/net/ethernet/cavium/liquidio/lio_main.c
> index 66d31c018c7e..f18085262982 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
> @@ -801,6 +801,7 @@ static int liquidio_watchdog(void *param)
>  			continue;
> 
>  		WRITE_ONCE(oct->cores_crashed, true);
> +		module_firmware_crashed();
>  		other_oct = get_other_octeon_device(oct);
>  		if (other_oct)
>  			WRITE_ONCE(other_oct->cores_crashed, true);
> --
> 2.25.1

Thanks!

Reviewed-by: Derek Chickles <dchickles@marvell.com>

[PATCH 06/15] liquidio: use new module_firmware_crashed()

[Luis Chamberlain]

This makes use of the new module_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.

Using a taint flag allows us to annotate when this happens clearly.

Cc: Derek Chickles <dchickles@marvell.com>
Cc: Satanand Burla <sburla@marvell.com>
Cc: Felix Manlunas <fmanlunas@marvell.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index 66d31c018c7e..f18085262982 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -801,6 +801,7 @@ static int liquidio_watchdog(void *param)
 			continue;
 
 		WRITE_ONCE(oct->cores_crashed, true);
+		module_firmware_crashed();
 		other_oct = get_other_octeon_device(oct);
 		if (other_oct)
 			WRITE_ONCE(other_oct->cores_crashed, true);
-- 
2.25.1