* Data race on dev->mtu betwen __dev_set_mtu() and rawv6_send_hdrinc()
@ 2021-02-22 23:28 Gong, Sishuai
2021-02-23 15:25 ` Willem de Bruijn
0 siblings, 1 reply; 2+ messages in thread
From: Gong, Sishuai @ 2021-02-22 23:28 UTC (permalink / raw)
To: davem, yoshfuji, dsahern; +Cc: netdev
Hello,
We found a data race on dev->mtu between function __dev_set_mtu() and rawv6_send_hdrinc(). It happens with the following interleaving.
writer: __dev_set_mtu() reader: rawv6_send_hdrinc()
if (length > rt->dst.dev->mtu) {
WRITE_ONCE(dev->mtu, new_mtu);
ipv6_local_error(sk, EMSGSIZE, fl6, rt->dst.dev->mtu);
If the writer happens to change dev->mtu to a value that is bigger than the variable ‘length’, then ipv6_local_error will read a value that doesn’t satisfy this conditional statement. While there is no need to use lock to protect the read, it is probably better to only read dev->mtu once in rawv6_send_hdrinc().
Thanks,
Sishuai
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Data race on dev->mtu betwen __dev_set_mtu() and rawv6_send_hdrinc()
2021-02-22 23:28 Data race on dev->mtu betwen __dev_set_mtu() and rawv6_send_hdrinc() Gong, Sishuai
@ 2021-02-23 15:25 ` Willem de Bruijn
0 siblings, 0 replies; 2+ messages in thread
From: Willem de Bruijn @ 2021-02-23 15:25 UTC (permalink / raw)
To: Gong, Sishuai; +Cc: davem, yoshfuji, dsahern, netdev
On Mon, Feb 22, 2021 at 6:30 PM Gong, Sishuai <sishuai@purdue.edu> wrote:
>
> Hello,
>
> We found a data race on dev->mtu between function __dev_set_mtu() and rawv6_send_hdrinc(). It happens with the following interleaving.
>
> writer: __dev_set_mtu() reader: rawv6_send_hdrinc()
> if (length > rt->dst.dev->mtu) {
> WRITE_ONCE(dev->mtu, new_mtu);
> ipv6_local_error(sk, EMSGSIZE, fl6, rt->dst.dev->mtu);
>
> If the writer happens to change dev->mtu to a value that is bigger than the variable ‘length’, then ipv6_local_error will read a value that doesn’t satisfy this conditional statement. While there is no need to use lock to protect the read, it is probably better to only read dev->mtu once in rawv6_send_hdrinc().
Makes sense. The same would then apply to raw_send_hdrinc().
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-23 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 23:28 Data race on dev->mtu betwen __dev_set_mtu() and rawv6_send_hdrinc() Gong, Sishuai
2021-02-23 15:25 ` Willem de Bruijn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).