From: Alexandru Ardelean <ardeleanalex@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux@armlinux.org.uk, David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2 2/2] net: phy: adin: implement cable-test support
Date: Fri, 23 Oct 2020 16:25:33 +0300 [thread overview]
Message-ID: <CA+U=Dsp+AnhHe87-7FXTekf5KqC3arYsy_46FEcZjQJTBWq8-Q@mail.gmail.com> (raw)
In-Reply-To: <20201022170219.13b03274@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On Fri, Oct 23, 2020 at 3:02 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 22 Oct 2020 10:45:51 +0300 Alexandru Ardelean wrote:
> > The ADIN1300/ADIN1200 support cable diagnostics using TDR.
> >
> > The cable fault detection is automatically run on all four pairs looking at
> > all combinations of pair faults by first putting the PHY in standby (clear
> > the LINK_EN bit, PHY_CTRL_3 register, Address 0x0017) and then enabling the
> > diagnostic clock (set the DIAG_CLK_EN bit, PHY_CTRL_1 register, Address
> > 0x0012).
> >
> > Cable diagnostics can then be run (set the CDIAG_RUN bit in the
> > CDIAG_RUN register, Address 0xBA1B). The results are reported for each pair
> > in the cable diagnostics results registers, CDIAG_DTLD_RSLTS_0,
> > CDIAG_DTLD_RSLTS_1, CDIAG_DTLD_RSLTS_2, and CDIAG_DTLD_RSLTS_3, Address
> > 0xBA1D to Address 0xBA20).
> >
> > The distance to the first fault for each pair is reported in the cable
> > fault distance registers, CDIAG_FLT_DIST_0, CDIAG_FLT_DIST_1,
> > CDIAG_FLT_DIST_2, and CDIAG_FLT_DIST_3, Address 0xBA21 to Address 0xBA24).
> >
> > This change implements support for this using phylib's cable-test support.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> # Form letter - net-next is closed
>
> We have already sent a pull request for 5.10 and therefore net-next
> is closed for new drivers, features, and code refactoring.
>
> Please repost when net-next reopens after 5.10-rc1 is cut.
>
Ack.
No hurry from my side.
Thanks
Alex
> (http://vger.kernel.org/~davem/net-next.html will not be up to date
> this time around, sorry about that).
>
> RFC patches sent for review only are obviously welcome at any time.
next prev parent reply other threads:[~2020-10-23 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 7:45 [PATCH v2 1/2] net: phy: adin: disable diag clock & disable standby mode in config_aneg Alexandru Ardelean
2020-10-22 7:45 ` [PATCH v2 2/2] net: phy: adin: implement cable-test support Alexandru Ardelean
2020-10-23 0:02 ` Jakub Kicinski
2020-10-23 13:25 ` Alexandru Ardelean [this message]
2020-10-23 22:48 ` Andrew Lunn
2020-10-23 22:43 ` [PATCH v2 1/2] net: phy: adin: disable diag clock & disable standby mode in config_aneg Andrew Lunn
2020-10-31 12:16 ` Alexandru Ardelean
2020-10-31 14:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+U=Dsp+AnhHe87-7FXTekf5KqC3arYsy_46FEcZjQJTBWq8-Q@mail.gmail.com' \
--to=ardeleanalex@gmail.com \
--cc=alexandru.ardelean@analog.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).