From: Alexandru Ardelean <ardeleanalex@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux@armlinux.org.uk, David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v2 1/2] net: phy: adin: disable diag clock & disable standby mode in config_aneg
Date: Sat, 31 Oct 2020 14:16:07 +0200 [thread overview]
Message-ID: <CA+U=Dsr3pbZspQu13YmZSLthgCeMNx_7guWTwLtb8vETbVsT_A@mail.gmail.com> (raw)
In-Reply-To: <20201023224336.GF745568@lunn.ch>
On Sat, Oct 24, 2020 at 1:43 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Thu, Oct 22, 2020 at 10:45:50AM +0300, Alexandru Ardelean wrote:
> > When the PHY powers up, the diagnostics clock isn't enabled (bit 2 in
> > register PHY_CTRL_1 (0x0012)).
> > Also, the PHY is not in standby mode, so bit 13 in PHY_CTRL_3 (0x0017) is
> > always set at power up.
> >
> > The standby mode and the diagnostics clock are both meant to be for the
> > cable diagnostics feature of the PHY (in phylib this would be equivalent to
> > the cable-test support), and for the frame-generator feature of the PHY.
> >
> > In standby mode, the PHY doesn't negotiate links or manage links.
> >
> > To use the cable diagnostics/test (or frame-generator), the PHY must be
> > first set in standby mode, so that the link operation doesn't interfere.
> > Then, the diagnostics clock must be enabled.
> >
> > For the cable-test feature, when the operation finishes, the PHY goes into
> > PHY_UP state, and the config_aneg hook is called.
> >
> > For the ADIN PHY, we need to make sure that during autonegotiation
> > configuration/setup the PHY is removed from standby mode and the
> > diagnostics clock is disabled, so that normal operation is resumed.
> >
> > This change does that by moving the set of the ADIN1300_LINKING_EN bit (2)
> > in the config_aneg (to disable standby mode).
> > Previously, this was set in the downshift setup, because the downshift
> > retry value and the ADIN1300_LINKING_EN are in the same register.
> >
> > And the ADIN1300_DIAG_CLK_EN bit (13) is cleared, to disable the
> > diagnostics clock.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
So, then re-send for this or just this patch ping?
Naturally, this is for net-next.
I don't mind doing either way.
Thanks
Alex
>
> Andrew
next prev parent reply other threads:[~2020-10-31 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 7:45 [PATCH v2 1/2] net: phy: adin: disable diag clock & disable standby mode in config_aneg Alexandru Ardelean
2020-10-22 7:45 ` [PATCH v2 2/2] net: phy: adin: implement cable-test support Alexandru Ardelean
2020-10-23 0:02 ` Jakub Kicinski
2020-10-23 13:25 ` Alexandru Ardelean
2020-10-23 22:48 ` Andrew Lunn
2020-10-23 22:43 ` [PATCH v2 1/2] net: phy: adin: disable diag clock & disable standby mode in config_aneg Andrew Lunn
2020-10-31 12:16 ` Alexandru Ardelean [this message]
2020-10-31 14:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+U=Dsr3pbZspQu13YmZSLthgCeMNx_7guWTwLtb8vETbVsT_A@mail.gmail.com' \
--to=ardeleanalex@gmail.com \
--cc=alexandru.ardelean@analog.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).