* [PATCH] net: dsa: sja1105: Add missing spin_unlock
@ 2019-07-17 14:12 YueHaibing
2019-07-17 18:00 ` Vladimir Oltean
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-07-17 14:12 UTC (permalink / raw)
To: andrew, vivien.didelot, f.fainelli, davem, olteanv
Cc: linux-kernel, netdev, YueHaibing
It should call spin_unlock() before return NULL.
Detected by Coccinelle.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: f3097be21bf1 net: ("dsa: sja1105: Add a state machine for RX timestamping")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/dsa/tag_sja1105.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c
index 1d96c9d..26363d7 100644
--- a/net/dsa/tag_sja1105.c
+++ b/net/dsa/tag_sja1105.c
@@ -216,6 +216,7 @@ static struct sk_buff
if (!skb) {
dev_err_ratelimited(dp->ds->dev,
"Failed to copy stampable skb\n");
+ spin_unlock(&sp->data->meta_lock);
return NULL;
}
sja1105_transfer_meta(skb, meta);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: dsa: sja1105: Add missing spin_unlock
2019-07-17 14:12 [PATCH] net: dsa: sja1105: Add missing spin_unlock YueHaibing
@ 2019-07-17 18:00 ` Vladimir Oltean
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Oltean @ 2019-07-17 18:00 UTC (permalink / raw)
To: YueHaibing
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, David S. Miller,
lkml, netdev
On Wed, 17 Jul 2019 at 17:12, YueHaibing <yuehaibing@huawei.com> wrote:
>
> It should call spin_unlock() before return NULL.
> Detected by Coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: f3097be21bf1 net: ("dsa: sja1105: Add a state machine for RX timestamping")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Hi Yue,
Thanks for the patch. Wei Yongjun submitted an identical one a few
hours before yours: https://patchwork.ozlabs.org/patch/1133135/
Let's go with that version this time.
> net/dsa/tag_sja1105.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c
> index 1d96c9d..26363d7 100644
> --- a/net/dsa/tag_sja1105.c
> +++ b/net/dsa/tag_sja1105.c
> @@ -216,6 +216,7 @@ static struct sk_buff
> if (!skb) {
> dev_err_ratelimited(dp->ds->dev,
> "Failed to copy stampable skb\n");
> + spin_unlock(&sp->data->meta_lock);
> return NULL;
> }
> sja1105_transfer_meta(skb, meta);
> --
> 2.7.4
>
>
Regards,
-Vladimir
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-17 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 14:12 [PATCH] net: dsa: sja1105: Add missing spin_unlock YueHaibing
2019-07-17 18:00 ` Vladimir Oltean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).