From: Vladimir Oltean <olteanv@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Joergen Andreasen <joergen.andreasen@microchip.com>,
"Allan W. Nielsen" <allan.nielsen@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
netdev <netdev@vger.kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net-next 10/12] net: dsa: vitesse: move vsc73xx driver to a separate folder
Date: Tue, 12 Nov 2019 15:40:35 +0200 [thread overview]
Message-ID: <CA+h21hqYynoGwfd=g3rZFgYSKNxsv8PXstD+6btopykweEi1dw@mail.gmail.com> (raw)
In-Reply-To: <20191112130947.GE3572@piout.net>
On Tue, 12 Nov 2019 at 15:09, Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> Hi,
>
> On 12/11/2019 14:44:18+0200, Vladimir Oltean wrote:
> > From: Vladimir Oltean <vladimir.oltean@nxp.com>
> >
> > The vitesse/ folder will contain drivers for switching chips derived
> > from legacy Vitesse IPs (VSC family), including those produced by
> > Microsemi and Microchip (acquirers of Vitesse).
> >
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > ---
> > drivers/net/dsa/Kconfig | 31 +------------------
> > drivers/net/dsa/Makefile | 4 +--
> > drivers/net/dsa/vitesse/Kconfig | 31 +++++++++++++++++++
> > drivers/net/dsa/vitesse/Makefile | 3 ++
> > .../vsc73xx-core.c} | 2 +-
> > .../vsc73xx-platform.c} | 2 +-
> > .../vsc73xx-spi.c} | 2 +-
> > .../{vitesse-vsc73xx.h => vitesse/vsc73xx.h} | 0
> > 8 files changed, 39 insertions(+), 36 deletions(-)
> > create mode 100644 drivers/net/dsa/vitesse/Kconfig
> > create mode 100644 drivers/net/dsa/vitesse/Makefile
> > rename drivers/net/dsa/{vitesse-vsc73xx-core.c => vitesse/vsc73xx-core.c} (99%)
> > rename drivers/net/dsa/{vitesse-vsc73xx-platform.c => vitesse/vsc73xx-platform.c} (99%)
> > rename drivers/net/dsa/{vitesse-vsc73xx-spi.c => vitesse/vsc73xx-spi.c} (99%)
> > rename drivers/net/dsa/{vitesse-vsc73xx.h => vitesse/vsc73xx.h} (100%)
> >
>
> As there are no commonalities between the vsc73xx and felix drivers,
> shouldn't you simply leave that one out and have felix in the existing
> microchip folder?
>
I don't have a strong preference, although where I come from, all new
NXP networking drivers are still labeled as "freescale" even though
there is no code reuse. There are even less commonalities with
Microchip (ex-Micrel, if I am not mistaken) KSZ switches than with the
old vsc73xx. I'll let the ex-Vitesse people decide.
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
next prev parent reply other threads:[~2019-11-12 13:40 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 12:44 [PATCH net-next 00/12] DSA driver for Vitesse Felix switch Vladimir Oltean
2019-11-12 12:44 ` [PATCH net-next 01/12] net: mscc: ocelot: move resource ioremap and regmap init to common code Vladimir Oltean
2019-11-12 12:44 ` [PATCH net-next 02/12] net: mscc: ocelot: filter out ocelot SoC specific PCS config from common path Vladimir Oltean
2019-11-12 13:31 ` Andrew Lunn
2019-11-12 21:28 ` Florian Fainelli
2019-11-13 9:40 ` kbuild test robot
2019-11-12 12:44 ` [PATCH net-next 03/12] net: mscc: ocelot: move invariant configs out of adjust_link Vladimir Oltean
2019-11-12 13:35 ` Andrew Lunn
2019-11-12 13:38 ` Vladimir Oltean
2019-11-12 21:30 ` Florian Fainelli
2019-11-12 12:44 ` [PATCH net-next 04/12] net: mscc: ocelot: create a helper for changing the port MTU Vladimir Oltean
2019-11-12 13:39 ` Andrew Lunn
2019-11-12 13:41 ` Vladimir Oltean
2019-11-12 21:31 ` Florian Fainelli
2019-11-12 12:44 ` [PATCH net-next 05/12] net: mscc: ocelot: export a constant for the tag length in bytes Vladimir Oltean
2019-11-12 13:44 ` Andrew Lunn
2019-11-12 21:32 ` Florian Fainelli
2019-11-12 12:44 ` [PATCH net-next 06/12] net: mscc: ocelot: adjust MTU on the CPU port in NPI mode Vladimir Oltean
2019-11-12 13:51 ` Andrew Lunn
2019-11-12 13:52 ` Vladimir Oltean
2019-11-12 13:57 ` Andrew Lunn
2019-11-12 21:32 ` Florian Fainelli
2019-11-12 12:44 ` [PATCH net-next 07/12] net: mscc: ocelot: separate the implementation of switch reset Vladimir Oltean
2019-11-12 13:55 ` Andrew Lunn
2019-11-12 13:59 ` Vladimir Oltean
2019-11-13 8:57 ` Alexandre Belloni
2019-11-12 21:34 ` Florian Fainelli
2019-11-12 12:44 ` [PATCH net-next 08/12] net: mscc: ocelot: publish structure definitions to include/soc/mscc/ocelot.h Vladimir Oltean
2019-11-12 14:42 ` Andrew Lunn
2019-11-12 16:18 ` Vladimir Oltean
2019-11-12 21:36 ` Florian Fainelli
2019-11-13 12:48 ` kbuild test robot
2019-11-12 12:44 ` [PATCH net-next 09/12] net: mscc: ocelot: publish ocelot_sys.h to include/soc/mscc Vladimir Oltean
2019-11-12 21:38 ` Florian Fainelli
2019-11-12 12:44 ` [PATCH net-next 10/12] net: dsa: vitesse: move vsc73xx driver to a separate folder Vladimir Oltean
2019-11-12 13:09 ` Alexandre Belloni
2019-11-12 13:40 ` Vladimir Oltean [this message]
2019-11-12 14:33 ` Allan W. Nielsen
2019-11-12 14:50 ` Andrew Lunn
2019-11-12 14:57 ` Allan W. Nielsen
2019-11-12 15:26 ` Vladimir Oltean
2019-11-12 19:09 ` Allan W. Nielsen
2019-11-12 19:26 ` Vladimir Oltean
2019-11-12 19:48 ` Allan W. Nielsen
2019-11-12 20:01 ` Vladimir Oltean
2019-11-13 7:38 ` Allan W. Nielsen
2019-11-13 8:47 ` Alexandre Belloni
2019-11-12 21:49 ` Florian Fainelli
2019-11-12 12:44 ` [PATCH net-next 11/12] net: dsa: vitesse: add basic Felix switch driver Vladimir Oltean
2019-11-12 12:44 ` [PATCH net-next 12/12] net: dsa: vitesse: add tagger for Ocelot/Felix switches Vladimir Oltean
2019-11-12 21:48 ` Florian Fainelli
2019-11-13 2:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+h21hqYynoGwfd=g3rZFgYSKNxsv8PXstD+6btopykweEi1dw@mail.gmail.com' \
--to=olteanv@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=jakub.kicinski@netronome.com \
--cc=joergen.andreasen@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).