Re: [PATCH net-next 10/12] net: dsa: vitesse: move vsc73xx driver to a separate folder

From: Vladimir Oltean <olteanv@gmail.com>
To: "Allan W. Nielsen" <allan.nielsen@microchip.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Joergen Andreasen <joergen.andreasen@microchip.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	netdev <netdev@vger.kernel.org>,
	Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net-next 10/12] net: dsa: vitesse: move vsc73xx driver to a separate folder
Date: Tue, 12 Nov 2019 17:26:46 +0200	[thread overview]
Message-ID: <CA+h21hrc-vb412iK+hp20K6huFPBABx6xYQjgi7Ew7ET8ryK+g@mail.gmail.com> (raw)
In-Reply-To: <20191112145732.o7pkbitrvrr2bb7j@lx-anielsen.microsemi.net>

On Tue, 12 Nov 2019 at 16:57, Allan W. Nielsen
<allan.nielsen@microchip.com> wrote:
>
> The 11/12/2019 15:50, Andrew Lunn wrote:
> > External E-Mail
> >
> >
> > > > > As there are no commonalities between the vsc73xx and felix drivers,
> > > > > shouldn't you simply leave that one out and have felix in the existing
> > > > > microchip folder?
> > > > >
> > > >
> > > > I don't have a strong preference, although where I come from, all new
> > > > NXP networking drivers are still labeled as "freescale" even though
> > > > there is no code reuse. There are even less commonalities with
> > > > Microchip (ex-Micrel, if I am not mistaken) KSZ switches than with the
> > > > old vsc73xx. I'll let the ex-Vitesse people decide.
> > > I'm on the same page as Alexandre here.
> >
> > Leaving them where they are makes maintenance easier. Fixes are easier
> > to backport if things don't move around.
> >
> > > I think we should leave vsc73xx where it is already, and put the felix driver in
> > > the drivers/net/ethernet/mscc/ folder where ocelot is already.
> >
> > Currently, all DSA drivers are in drivers/net/dsa. We do occasionally
> > make changes over all DSA drivers at once, so it is nice they are all
> > together. So i would prefer the DSA part of Felix is also there. But
> > the core can be in drivers/net/ethernet/mscc/.
> Ahh, my bad.
>
> In that case I do not have any strong feelings on this either.
>
> I should say that we are discussing to add support for a Ocelot VSC7511 as a DSA
> driver. This one does not have an internal MIPS CPU.
>
> The vsc73xx, felix and the drivers in dsa/microchip does not share any
> functionallity. Not in SW and not in HW.
>
> Maybe felix should just go directly into drivers/net/dsa/, and then if we add
> support for VSC7511 then they can both live in drivers/net/dsa/ocelot/
>
> /Allan

When the felix driver is going to support the vsc7511 ocelot switch
through the ocelot core, it will be naming chaos. Maybe we need to
clarify what "felix" means (at the moment it means VSC9959). What if
we just make it mean "DSA driver for Ocelot", and it supports both the
VSC751x (Ocelot) and the VSC9959 (Felix) families? Is anybody else
instantiating the VSC9959 core, or close derivatives, except NXP
LS1028A? If the answer is yes, are those other instantiations PCI
devices, or something else? I would appreciate if you could take a
look through the probing part of patch 11/12 (the "felix_instance_tbl"
part and felix-regs.c) and see if there are any naming changes I can
make that would make it easier for you to fit in one more device. Of
course, I don't expect to make radical changes, you'd still need to do
some refactoring if you decide to add your vsc7511, I just care that
the refactoring doesn't change any current semantics.

Regards,
-Vladimir