netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: "Hemminger, Stephen" <stephen@networkplumber.org>,
	netdev <netdev@vger.kernel.org>,
	Si-Wei Liu <si-wei.liu@oracle.com>,
	Jianbo Liu <jianbol@nvidia.com>
Subject: Re: [PATCH 2/3] virtio: Define bit numbers for device independent features
Date: Thu, 10 Feb 2022 15:54:57 +0800	[thread overview]
Message-ID: <CACGkMEvF7opCo35QLz4p3u7=T1+H-p=isFm4+yh4uNzKiAxr1A@mail.gmail.com> (raw)
In-Reply-To: <20220207125537.174619-3-elic@nvidia.com>

On Mon, Feb 7, 2022 at 8:56 PM Eli Cohen <elic@nvidia.com> wrote:
>
> Define bit fields for device independent feature bits. We need them in a
> follow up patch.
>
> Also, define macros for start and end of these feature bits.
>
> Reviewed-by: Jianbo Liu <jianbol@nvidia.com>
> Signed-off-by: Eli Cohen <elic@nvidia.com>
> ---
>  include/uapi/linux/virtio_config.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h
> index 3bf6c8bf8477..6d92cc31a8d3 100644
> --- a/include/uapi/linux/virtio_config.h
> +++ b/include/uapi/linux/virtio_config.h
> @@ -45,14 +45,14 @@
>  /* We've given up on this device. */
>  #define VIRTIO_CONFIG_S_FAILED         0x80
>
> -/*
> - * Virtio feature bits VIRTIO_TRANSPORT_F_START through
> - * VIRTIO_TRANSPORT_F_END are reserved for the transport
> - * being used (e.g. virtio_ring, virtio_pci etc.), the
> - * rest are per-device feature bits.
> - */
> -#define VIRTIO_TRANSPORT_F_START       28
> -#define VIRTIO_TRANSPORT_F_END         38
> +/* Device independent features per virtio spec 1.1 range from 28 to 38 */
> +#define VIRTIO_DEV_INDEPENDENT_F_START 28
> +#define VIRTIO_DEV_INDEPENDENT_F_END   38

Haven't gone through patch 3 but I think it's probably better not
touch uapi stuff. Or we can define those macros in other place?

> +
> +#define VIRTIO_F_RING_INDIRECT_DESC 28
> +#define VIRTIO_F_RING_EVENT_IDX 29
> +#define VIRTIO_F_IN_ORDER 35
> +#define VIRTIO_F_NOTIFICATION_DATA 38

This part belongs to the virtio_ring.h any reason not pull that file
instead of squashing those into virtio_config.h?

Thanks

>
>  #ifndef VIRTIO_CONFIG_NO_LEGACY
>  /* Do we get callbacks when the ring is completely used, even if we've
> --
> 2.34.1
>


  reply	other threads:[~2022-02-10  7:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 12:55 [PATCH 0/3] vdpa tool support for configuring max VQs Eli Cohen
2022-02-07 12:55 ` [PATCH 1/3] vdpa: Remove unsupported command line option Eli Cohen
2022-02-10  7:50   ` Jason Wang
2022-02-07 12:55 ` [PATCH 2/3] virtio: Define bit numbers for device independent features Eli Cohen
2022-02-10  7:54   ` Jason Wang [this message]
2022-02-10  8:30     ` Eli Cohen
2022-02-10  8:35       ` Jason Wang
2022-02-10  9:27         ` Eli Cohen
2022-02-14  6:06           ` Jason Wang
2022-02-16  7:15             ` Eli Cohen
2022-02-17  6:06               ` Jason Wang
2022-02-17  8:26                 ` Eli Cohen
2022-02-07 12:55 ` [PATCH 3/3] vdpa: Add support to configure max number of VQs Eli Cohen
2022-02-10  8:07   ` Jason Wang
2022-02-10  8:44     ` Eli Cohen
2022-02-10  8:51       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACGkMEvF7opCo35QLz4p3u7=T1+H-p=isFm4+yh4uNzKiAxr1A@mail.gmail.com' \
    --to=jasowang@redhat.com \
    --cc=elic@nvidia.com \
    --cc=jianbol@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=si-wei.liu@oracle.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).