From: Soheil Hassas Yeganeh <soheil@google.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, Van Jacobson <vanj@google.com>,
Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next 2/2] tcp: do not aggressively quick ack after ECN events
Date: Tue, 22 May 2018 10:04:28 -0400 [thread overview]
Message-ID: <CACSApvYiF90axDXAKk7_z5LmfbvxORPR282Ltxj+sRAHWLy6xg@mail.gmail.com> (raw)
In-Reply-To: <20180521220857.229273-3-edumazet@google.com>
On Mon, May 21, 2018 at 6:08 PM, Eric Dumazet <edumazet@google.com> wrote:
> ECN signals currently forces TCP to enter quickack mode for
> up to 16 (TCP_MAX_QUICKACKS) following incoming packets.
>
> We believe this is not needed, and only sending one immediate ack
> for the current packet should be enough.
>
> This should reduce the extra load noticed in DCTCP environments,
> after congestion events.
>
> This is part 2 of our effort to reduce pure ACK packets.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Thanks for the patch!
next prev parent reply other threads:[~2018-05-22 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 22:08 [PATCH net-next 0/2] tcp: reduce quickack pressure for ECN Eric Dumazet
2018-05-21 22:08 ` [PATCH net-next 1/2] tcp: add max_quickacks param to tcp_incr_quickack and tcp_enter_quickack_mode Eric Dumazet
2018-05-22 14:03 ` Soheil Hassas Yeganeh
2018-05-22 17:27 ` Neal Cardwell
2018-05-23 0:30 ` kbuild test robot
2018-05-23 1:37 ` Neal Cardwell
2018-05-21 22:08 ` [PATCH net-next 2/2] tcp: do not aggressively quick ack after ECN events Eric Dumazet
2018-05-22 14:04 ` Soheil Hassas Yeganeh [this message]
2018-05-22 16:54 ` Yuchung Cheng
2018-05-22 17:36 ` Neal Cardwell
2018-05-22 19:43 ` [PATCH net-next 0/2] tcp: reduce quickack pressure for ECN David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACSApvYiF90axDXAKk7_z5LmfbvxORPR282Ltxj+sRAHWLy6xg@mail.gmail.com \
--to=soheil@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=vanj@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).