From: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com>
To: Bill Sommerfeld <wsommerfeld@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Petr Machata <petrm@mellanox.com>, Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
Daniel Borkmann <daniel@iogearbox.net>,
YueHaibing <yuehaibing@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>,
Miaohe Lin <linmiaohe@huawei.com>,
Eric Dumazet <edumazet@google.com>,
linux-netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipvlan: set hw_enc_features like macvlan
Date: Thu, 15 Aug 2019 18:03:16 -0700 [thread overview]
Message-ID: <CAF2d9jgRk7EVNNcZe+y+PRh3EkYTVJ794SXa4RNYXAu3-7ktNQ@mail.gmail.com> (raw)
In-Reply-To: <20190815001043.153874-1-wsommerfeld@google.com>
On Wed, Aug 14, 2019 at 5:10 PM Bill Sommerfeld <wsommerfeld@google.com> wrote:
>
> Allow encapsulated packets sent to tunnels layered over ipvlan to use
> offloads rather than forcing SW fallbacks.
>
> Since commit f21e5077010acda73a60 ("macvlan: add offload features for
> encapsulation"), macvlan has set dev->hw_enc_features to include
> everything in dev->features; do likewise in ipvlan.
>
Thanks Bill
> Signed-off-by: Bill Sommerfeld <wsommerfeld@google.com>
Acked-by: Mahesh Bandewar <maheshb@google.com>
> ---
> drivers/net/ipvlan/ipvlan_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 1c96bed5a7c4..887bbba4631e 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -126,6 +126,7 @@ static int ipvlan_init(struct net_device *dev)
> (phy_dev->state & IPVLAN_STATE_MASK);
> dev->features = phy_dev->features & IPVLAN_FEATURES;
> dev->features |= NETIF_F_LLTX | NETIF_F_VLAN_CHALLENGED;
> + dev->hw_enc_features |= dev->features;
> dev->gso_max_size = phy_dev->gso_max_size;
> dev->gso_max_segs = phy_dev->gso_max_segs;
> dev->hard_header_len = phy_dev->hard_header_len;
> --
> 2.23.0.rc1.153.gdeed80330f-goog
>
next prev parent reply other threads:[~2019-08-16 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 0:10 [PATCH] ipvlan: set hw_enc_features like macvlan Bill Sommerfeld
2019-08-16 1:03 ` Mahesh Bandewar (महेश बंडेवार) [this message]
2019-08-16 22:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF2d9jgRk7EVNNcZe+y+PRh3EkYTVJ794SXa4RNYXAu3-7ktNQ@mail.gmail.com \
--to=maheshb@google.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=tglx@linutronix.de \
--cc=wsommerfeld@google.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).