* [PATCH bpf-next] bpf: make LWTUNNEL_BPF dependent on INET
@ 2019-02-15 17:40 Peter Oskolkov
2019-02-15 17:46 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Peter Oskolkov @ 2019-02-15 17:40 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, netdev
Cc: Peter Oskolkov, Peter Oskolkov
Lightweight tunnels are L3 constructs that are used with IP/IP6.
Make the dependency explicit at least for LWT-BPF, as now they
call into IP routing.
Signed-off-by: Peter Oskolkov <posk@google.com>
---
net/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/Kconfig b/net/Kconfig
index 5cb9de1aaf88..62da6148e9f8 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -403,7 +403,7 @@ config LWTUNNEL
config LWTUNNEL_BPF
bool "Execute BPF program as route nexthop action"
- depends on LWTUNNEL
+ depends on LWTUNNEL && INET
default y if LWTUNNEL=y
---help---
Allows to run BPF programs as a nexthop action following a route
--
2.21.0.rc0.258.g878e2cd30e-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] bpf: make LWTUNNEL_BPF dependent on INET
2019-02-15 17:40 [PATCH bpf-next] bpf: make LWTUNNEL_BPF dependent on INET Peter Oskolkov
@ 2019-02-15 17:46 ` Eric Dumazet
2019-02-15 17:53 ` Peter Oskolkov
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2019-02-15 17:46 UTC (permalink / raw)
To: Peter Oskolkov, Alexei Starovoitov, Daniel Borkmann, netdev
Cc: Peter Oskolkov
On 02/15/2019 09:40 AM, Peter Oskolkov wrote:
> Lightweight tunnels are L3 constructs that are used with IP/IP6.
> Make the dependency explicit at least for LWT-BPF, as now they
> call into IP routing.
>
> Signed-off-by: Peter Oskolkov <posk@google.com>
> ---
> net/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/Kconfig b/net/Kconfig
> index 5cb9de1aaf88..62da6148e9f8 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -403,7 +403,7 @@ config LWTUNNEL
>
> config LWTUNNEL_BPF
> bool "Execute BPF program as route nexthop action"
> - depends on LWTUNNEL
> + depends on LWTUNNEL && INET
> default y if LWTUNNEL=y
> ---help---
> Allows to run BPF programs as a nexthop action following a route
>
It seems you forgot a 'Reported-by:' tag
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] bpf: make LWTUNNEL_BPF dependent on INET
2019-02-15 17:46 ` Eric Dumazet
@ 2019-02-15 17:53 ` Peter Oskolkov
0 siblings, 0 replies; 3+ messages in thread
From: Peter Oskolkov @ 2019-02-15 17:53 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Peter Oskolkov, Alexei Starovoitov, Daniel Borkmann, netdev
On Fri, Feb 15, 2019 at 9:46 AM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
>
> On 02/15/2019 09:40 AM, Peter Oskolkov wrote:
> > Lightweight tunnels are L3 constructs that are used with IP/IP6.
> > Make the dependency explicit at least for LWT-BPF, as now they
> > call into IP routing.
> >
> > Signed-off-by: Peter Oskolkov <posk@google.com>
> > ---
> > net/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/Kconfig b/net/Kconfig
> > index 5cb9de1aaf88..62da6148e9f8 100644
> > --- a/net/Kconfig
> > +++ b/net/Kconfig
> > @@ -403,7 +403,7 @@ config LWTUNNEL
> >
> > config LWTUNNEL_BPF
> > bool "Execute BPF program as route nexthop action"
> > - depends on LWTUNNEL
> > + depends on LWTUNNEL && INET
> > default y if LWTUNNEL=y
> > ---help---
> > Allows to run BPF programs as a nexthop action following a route
> >
>
> It seems you forgot a 'Reported-by:' tag
Fixed: https://patchwork.ozlabs.org/patch/1043108/
>
> Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-15 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-15 17:40 [PATCH bpf-next] bpf: make LWTUNNEL_BPF dependent on INET Peter Oskolkov
2019-02-15 17:46 ` Eric Dumazet
2019-02-15 17:53 ` Peter Oskolkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).