From: Cong Wang <cwang@twopensource.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: David Miller <davem@davemloft.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Alexei Starovoitov <ast@plumgrid.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] handle_ing update
Date: Mon, 11 May 2015 15:48:14 -0700 [thread overview]
Message-ID: <CAHA+R7OH2moexqvJMHG-Mhu16ycp0n7J3B4wHPbrEt-GPY5=Ag@mail.gmail.com> (raw)
In-Reply-To: <55512E39.2010203@iogearbox.net>
On Mon, May 11, 2015 at 3:33 PM, Daniel Borkmann <daniel@iogearbox.net> wrote:
> On 05/12/2015 12:03 AM, Cong Wang wrote:
> ...
>>
>> BTW, it should be protected by CONFIG_NET_SCH_INGRESS
>> rather than CONFIG_NET_CLS_ACT.
>
>
> Sure, I agree, this can further be improved. Feel free to send a patch.
I never agree on that approach, it makes the code even messy,
less readable. Correctness and readability are much more important
than a little performance gain, for me, not for you of course.
next prev parent reply other threads:[~2015-05-11 22:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 20:51 [PATCH net-next 0/2] handle_ing update Daniel Borkmann
2015-05-09 20:51 ` [PATCH net-next 1/2] net: sched: consolidate handle_ing and ing_filter Daniel Borkmann
2015-05-09 21:07 ` Alexei Starovoitov
2015-05-09 20:51 ` [PATCH net-next 2/2] net: sched: further simplify handle_ing Daniel Borkmann
2015-05-10 17:05 ` [PATCH net-next 0/2] handle_ing update Pablo Neira Ayuso
2015-05-10 17:55 ` Alexei Starovoitov
2015-05-10 18:06 ` Pablo Neira Ayuso
2015-05-11 15:09 ` David Miller
2015-05-11 22:03 ` Cong Wang
2015-05-11 22:23 ` Alexei Starovoitov
2015-05-11 22:42 ` Cong Wang
2015-05-11 22:33 ` Daniel Borkmann
2015-05-11 22:48 ` Cong Wang [this message]
2015-05-12 12:54 ` Pablo Neira Ayuso
2015-05-11 15:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHA+R7OH2moexqvJMHG-Mhu16ycp0n7J3B4wHPbrEt-GPY5=Ag@mail.gmail.com' \
--to=cwang@twopensource.com \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).