* [PATCH net-next] net: netlabel: Fix kerneldoc warnings
@ 2020-10-28 0:53 Andrew Lunn
2020-10-28 1:01 ` Paul Moore
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2020-10-28 0:53 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, Paul Moore, Andrew Lunn
net/netlabel/netlabel_calipso.c:376: warning: Function parameter or member 'ops' not described in 'netlbl_calipso_ops_register'
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
net/netlabel/netlabel_calipso.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/netlabel/netlabel_calipso.c b/net/netlabel/netlabel_calipso.c
index 4e62f2ad3575..a4efa99fb1f8 100644
--- a/net/netlabel/netlabel_calipso.c
+++ b/net/netlabel/netlabel_calipso.c
@@ -366,6 +366,7 @@ static const struct netlbl_calipso_ops *calipso_ops;
/**
* netlbl_calipso_ops_register - Register the CALIPSO operations
+ * @ops: Ops to register
*
* Description:
* Register the CALIPSO packet engine operations.
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: netlabel: Fix kerneldoc warnings
2020-10-28 0:53 [PATCH net-next] net: netlabel: Fix kerneldoc warnings Andrew Lunn
@ 2020-10-28 1:01 ` Paul Moore
0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2020-10-28 1:01 UTC (permalink / raw)
To: Andrew Lunn; +Cc: Jakub Kicinski, netdev
On Tue, Oct 27, 2020 at 8:54 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> net/netlabel/netlabel_calipso.c:376: warning: Function parameter or member 'ops' not described in 'netlbl_calipso_ops_register'
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> net/netlabel/netlabel_calipso.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/netlabel/netlabel_calipso.c b/net/netlabel/netlabel_calipso.c
> index 4e62f2ad3575..a4efa99fb1f8 100644
> --- a/net/netlabel/netlabel_calipso.c
> +++ b/net/netlabel/netlabel_calipso.c
> @@ -366,6 +366,7 @@ static const struct netlbl_calipso_ops *calipso_ops;
>
> /**
> * netlbl_calipso_ops_register - Register the CALIPSO operations
> + * @ops: Ops to register
If we are being nitpicky, it might be better to drop the
capitalization for the sake of consistency, e.g. "@ops: ops to
register".
Acked-by: Paul Moore <paul@paul-moore.com>
> *
> * Description:
> * Register the CALIPSO packet engine operations.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-29 0:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 0:53 [PATCH net-next] net: netlabel: Fix kerneldoc warnings Andrew Lunn
2020-10-28 1:01 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).