From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
thomas@sockpuppet.org, adhipati@tuta.io, dsahern@gmail.com,
toke@redhat.com, kuba@kernel.org, alexei.starovoitov@gmail.com
Subject: Re: [PATCH net v5] net: xdp: account for layer 3 packets in generic skb handler
Date: Fri, 14 Aug 2020 22:57:35 +0200 [thread overview]
Message-ID: <CAHmME9pQwHeVAseqzA9WYMeh1VHZKRRUc1J=VzWv_0Zoyf8uPg@mail.gmail.com> (raw)
In-Reply-To: <20200814.135546.2266851283177227377.davem@davemloft.net>
On 8/14/20, David Miller <davem@davemloft.net> wrote:
> From: "Jason A. Donenfeld" <Jason@zx2c4.com>
> Date: Fri, 14 Aug 2020 09:30:48 +0200
>
>> @@ -4676,6 +4688,7 @@ static u32 netif_receive_generic_xdp(struct sk_buff
>> *skb,
>> (orig_bcast != is_multicast_ether_addr_64bits(eth->h_dest))) {
>> __skb_push(skb, ETH_HLEN);
>> skb->protocol = eth_type_trans(skb, skb->dev);
>> + __skb_pull(skb, ETH_HLEN);
>> }
>>
>> switch (act) {
>
> This bug fix is separate from your other changes. Please do not combine
> them.
>
No problem. I'll split this out and resend tomorrow morning.
Jason
next prev parent reply other threads:[~2020-08-14 20:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 19:58 [PATCH net v4] net: xdp: account for layer 3 packets in generic skb handler Jason A. Donenfeld
2020-08-13 21:01 ` Jakub Kicinski
2020-08-14 6:56 ` Jason A. Donenfeld
2020-08-14 7:30 ` [PATCH net v5] " Jason A. Donenfeld
2020-08-14 20:55 ` David Miller
2020-08-14 20:57 ` Jason A. Donenfeld [this message]
2020-08-15 7:41 ` [PATCH net v6] " Jason A. Donenfeld
2020-08-19 7:07 ` Jesper Dangaard Brouer
2020-08-19 23:22 ` David Miller
2020-08-20 9:13 ` Jason A. Donenfeld
2020-08-20 18:55 ` David Miller
2020-08-20 20:29 ` Jason A. Donenfeld
2020-08-14 15:31 ` [PATCH net v4] " Jakub Kicinski
2020-08-14 21:04 ` Jason A. Donenfeld
2020-08-14 21:26 ` David Miller
2020-08-15 7:54 ` Jason A. Donenfeld
2020-08-14 21:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9pQwHeVAseqzA9WYMeh1VHZKRRUc1J=VzWv_0Zoyf8uPg@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=adhipati@tuta.io \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thomas@sockpuppet.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).