From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
thomas@sockpuppet.org, adhipati@tuta.io, dsahern@gmail.com,
toke@redhat.com, kuba@kernel.org, alexei.starovoitov@gmail.com,
brouer@redhat.com, john.fastabend@gmail.com,
daniel@iogearbox.net
Subject: Re: [PATCH net v6] net: xdp: account for layer 3 packets in generic skb handler
Date: Thu, 20 Aug 2020 22:29:26 +0200 [thread overview]
Message-ID: <CAHmME9qzVc-3ZzC-Bhxyb5TG85jkEicM+T+-nNU7_ez6+vS8RA@mail.gmail.com> (raw)
In-Reply-To: <20200820.115512.511642239854628332.davem@davemloft.net>
On 8/20/20, David Miller <davem@davemloft.net> wrote:
> From: "Jason A. Donenfeld" <Jason@zx2c4.com>
> Date: Thu, 20 Aug 2020 11:13:49 +0200
>
>> It seems like if an eBPF program pushes on a VLAN tag or changes the
>> protocol or does any other modification, it will be treated in exactly
>> the same way as the L2 packet above by the remaining parts of the
>> networking stack.
>
> What will update the skb metadata if the XDP program changes the
> wireguard header(s)?
>
XDP runs after decryption/decapsulation, in the netif_rx path, which
means there is no wireguard header at that point. All the wireguard
crypto/udp/header stuff is all inside the driver itself, and the rest
of the stack just deals in terms of plain vanilla L3 ipv4/ipv6
packets.
The skb->protocol metadata is handled by the fake ethernet header.
Is there other metadata I should keep in mind? WireGuard doesn't play
with skb_metadata_*, for example. (Though it may implicitly reach a
skb_metadata_clear via pskb_expand path.)
next prev parent reply other threads:[~2020-08-20 20:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 19:58 [PATCH net v4] net: xdp: account for layer 3 packets in generic skb handler Jason A. Donenfeld
2020-08-13 21:01 ` Jakub Kicinski
2020-08-14 6:56 ` Jason A. Donenfeld
2020-08-14 7:30 ` [PATCH net v5] " Jason A. Donenfeld
2020-08-14 20:55 ` David Miller
2020-08-14 20:57 ` Jason A. Donenfeld
2020-08-15 7:41 ` [PATCH net v6] " Jason A. Donenfeld
2020-08-19 7:07 ` Jesper Dangaard Brouer
2020-08-19 23:22 ` David Miller
2020-08-20 9:13 ` Jason A. Donenfeld
2020-08-20 18:55 ` David Miller
2020-08-20 20:29 ` Jason A. Donenfeld [this message]
2020-08-14 15:31 ` [PATCH net v4] " Jakub Kicinski
2020-08-14 21:04 ` Jason A. Donenfeld
2020-08-14 21:26 ` David Miller
2020-08-15 7:54 ` Jason A. Donenfeld
2020-08-14 21:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9qzVc-3ZzC-Bhxyb5TG85jkEicM+T+-nNU7_ez6+vS8RA@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=adhipati@tuta.io \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thomas@sockpuppet.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).