* stmmac: Reporting ethtool_ts_info
@ 2015-10-27 6:11 Phil Reid
2015-10-30 5:15 ` Rayagond Kokatanur
0 siblings, 1 reply; 2+ messages in thread
From: Phil Reid @ 2015-10-27 6:11 UTC (permalink / raw)
To: netdev; +Cc: peppe.cavallaro
G'day All,
The stmmac driver checks (priv->hwts_tx_en) && (priv->hwts_rx_en) before
reporting WHTSTAMP capabilities.
No other driver seems to do this. hwts_*_en indicate if timestamping is
enabled, not if the interface is capable of it.
Instead they check there capabilities. Which would be
(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)
Does this seem reasonable?
--
Regards
Phil Reid
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: stmmac: Reporting ethtool_ts_info
2015-10-27 6:11 stmmac: Reporting ethtool_ts_info Phil Reid
@ 2015-10-30 5:15 ` Rayagond Kokatanur
0 siblings, 0 replies; 2+ messages in thread
From: Rayagond Kokatanur @ 2015-10-30 5:15 UTC (permalink / raw)
To: Phil Reid; +Cc: netdev, Giuseppe Cavallaro
On Tue, Oct 27, 2015 at 11:41 AM, Phil Reid <preid@electromag.com.au> wrote:
> G'day All,
>
> The stmmac driver checks (priv->hwts_tx_en) && (priv->hwts_rx_en) before
> reporting WHTSTAMP capabilities.
> No other driver seems to do this. hwts_*_en indicate if timestamping is
> enabled, not if the interface is capable of it.
> Instead they check there capabilities. Which would be
> (priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)
Yes true.
priv->hwts_*_en indicate if timestamping is enabled/disabled at run
time. But priv->dma_cap.time_stamp and priv->dma_cap.atime_stamp
indicates HW is support for PTPv1/PTPv2.
We should use - (priv->dma_cap.time_stamp ||
priv->dma_cap.atime_stamp) in ethtool_ts_ops.
wwr
Rayagond
>
> Does this seem reasonable?
>
>
> --
> Regards
> Phil Reid
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-30 5:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-27 6:11 stmmac: Reporting ethtool_ts_info Phil Reid
2015-10-30 5:15 ` Rayagond Kokatanur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).