* [PATCH net] mlx4_core: remove buggy sched_queue masking
@ 2012-03-05 14:54 Yevgeny Petrilin
2012-03-05 20:46 ` Roland Dreier
0 siblings, 1 reply; 3+ messages in thread
From: Yevgeny Petrilin @ 2012-03-05 14:54 UTC (permalink / raw)
To: davem; +Cc: netdev, yevgenyp, amirv
From: Amir Vadai <amirv@mellanox.co.il>
Fixes a bug introduced by commit fe9a2603c, where the priority bits
in the schedule queue field were masked out.
Signed-off-by: Amir Vadai <amirv@mellanox.co.il>
---
drivers/net/ethernet/mellanox/mlx4/qp.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/qp.c b/drivers/net/ethernet/mellanox/mlx4/qp.c
index 738f950..48ca886 100644
--- a/drivers/net/ethernet/mellanox/mlx4/qp.c
+++ b/drivers/net/ethernet/mellanox/mlx4/qp.c
@@ -152,9 +152,6 @@ static int __mlx4_qp_modify(struct mlx4_dev *dev, struct mlx4_mtt *mtt,
}
port = ((context->pri_path.sched_queue >> 6) & 1) + 1;
- if (dev->caps.port_type[port] == MLX4_PORT_TYPE_ETH)
- context->pri_path.sched_queue = (context->pri_path.sched_queue &
- 0xc3);
*(__be32 *) mailbox->buf = cpu_to_be32(optpar);
memcpy(mailbox->buf + 8, context, sizeof *context);
--
1.7.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] mlx4_core: remove buggy sched_queue masking
2012-03-05 14:54 [PATCH net] mlx4_core: remove buggy sched_queue masking Yevgeny Petrilin
@ 2012-03-05 20:46 ` Roland Dreier
2012-03-05 20:52 ` Or Gerlitz
0 siblings, 1 reply; 3+ messages in thread
From: Roland Dreier @ 2012-03-05 20:46 UTC (permalink / raw)
To: Yevgeny Petrilin; +Cc: davem, netdev, amirv
> port = ((context->pri_path.sched_queue >> 6) & 1) + 1;
This assignment of port seems to become dead code now...
> - if (dev->caps.port_type[port] == MLX4_PORT_TYPE_ETH)
> - context->pri_path.sched_queue = (context->pri_path.sched_queue &
> - 0xc3);
>
> *(__be32 *) mailbox->buf = cpu_to_be32(optpar);
> memcpy(mailbox->buf + 8, context, sizeof *context);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] mlx4_core: remove buggy sched_queue masking
2012-03-05 20:46 ` Roland Dreier
@ 2012-03-05 20:52 ` Or Gerlitz
0 siblings, 0 replies; 3+ messages in thread
From: Or Gerlitz @ 2012-03-05 20:52 UTC (permalink / raw)
To: Roland Dreier; +Cc: Yevgeny Petrilin, davem, netdev, amirv
Roland Dreier <roland@purestorage.com> wrote:
>> port = ((context->pri_path.sched_queue >> 6) & 1) + 1;
> This assignment of port seems to become dead code now...
good catch, yep, we will do this little cleanup and repost tomorrow,
however to make things clear, the point here was fixing that
regression.
Or.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-05 20:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-05 14:54 [PATCH net] mlx4_core: remove buggy sched_queue masking Yevgeny Petrilin
2012-03-05 20:46 ` Roland Dreier
2012-03-05 20:52 ` Or Gerlitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).