* [PATCH] bpfilter: re-add header search paths to tools include to fix build error
@ 2019-02-22 3:23 Masahiro Yamada
2019-02-22 5:54 ` Guenter Roeck
2019-02-23 21:36 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2019-02-22 3:23 UTC (permalink / raw)
To: David S . Miller, netdev, Guenter Roeck
Cc: Masahiro Yamada, Song Liu, Alexei Starovoitov, Yonghong Song,
linux-kernel, Martin KaFai Lau, Daniel Borkmann
I thought header search paths to tools/include(/uapi) were unneeded,
but it looks like a build error occurs depending on the compiler.
Commit 303a339f30a9 ("bpfilter: remove extra header search paths for
bpfilter_umh") reintroduced the build error fixed by commit ae40832e53c3
("bpfilter: fix a build err").
Apology for the breakage, and thanks to Guenter for reporting this.
Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Guenter,
Sorry for bothering you, but
could you please test this with your compiler?
I am also using GCC 7.3, but my compiler cannot
reproduce the build error.
net/bpfilter/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile
index 5d6c776..854395f 100644
--- a/net/bpfilter/Makefile
+++ b/net/bpfilter/Makefile
@@ -5,6 +5,7 @@
hostprogs-y := bpfilter_umh
bpfilter_umh-objs := main.o
+KBUILD_HOSTCFLAGS += -Itools/include/ -Itools/include/uapi
HOSTCC := $(CC)
ifeq ($(CONFIG_BPFILTER_UMH), y)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] bpfilter: re-add header search paths to tools include to fix build error
2019-02-22 3:23 [PATCH] bpfilter: re-add header search paths to tools include to fix build error Masahiro Yamada
@ 2019-02-22 5:54 ` Guenter Roeck
2019-02-22 8:23 ` Masahiro Yamada
2019-02-23 21:36 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2019-02-22 5:54 UTC (permalink / raw)
To: Masahiro Yamada, David S . Miller, netdev
Cc: Song Liu, Alexei Starovoitov, Yonghong Song, linux-kernel,
Martin KaFai Lau, Daniel Borkmann
On 2/21/19 7:23 PM, Masahiro Yamada wrote:
> I thought header search paths to tools/include(/uapi) were unneeded,
> but it looks like a build error occurs depending on the compiler.
>
> Commit 303a339f30a9 ("bpfilter: remove extra header search paths for
> bpfilter_umh") reintroduced the build error fixed by commit ae40832e53c3
> ("bpfilter: fix a build err").
>
> Apology for the breakage, and thanks to Guenter for reporting this.
>
> Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Guenter,
>
> Sorry for bothering you, but
> could you please test this with your compiler?
>
> I am also using GCC 7.3, but my compiler cannot
> reproduce the build error.
>
>
> net/bpfilter/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile
> index 5d6c776..854395f 100644
> --- a/net/bpfilter/Makefile
> +++ b/net/bpfilter/Makefile
> @@ -5,6 +5,7 @@
>
> hostprogs-y := bpfilter_umh
> bpfilter_umh-objs := main.o
> +KBUILD_HOSTCFLAGS += -Itools/include/ -Itools/include/uapi
> HOSTCC := $(CC)
>
> ifeq ($(CONFIG_BPFILTER_UMH), y)
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bpfilter: re-add header search paths to tools include to fix build error
2019-02-22 5:54 ` Guenter Roeck
@ 2019-02-22 8:23 ` Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2019-02-22 8:23 UTC (permalink / raw)
To: Guenter Roeck
Cc: David S . Miller, Networking, Song Liu, Alexei Starovoitov,
Yonghong Song, Linux Kernel Mailing List, Martin KaFai Lau,
Daniel Borkmann
On Fri, Feb 22, 2019 at 2:55 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 2/21/19 7:23 PM, Masahiro Yamada wrote:
> > I thought header search paths to tools/include(/uapi) were unneeded,
> > but it looks like a build error occurs depending on the compiler.
> >
> > Commit 303a339f30a9 ("bpfilter: remove extra header search paths for
> > bpfilter_umh") reintroduced the build error fixed by commit ae40832e53c3
> > ("bpfilter: fix a build err").
> >
> > Apology for the breakage, and thanks to Guenter for reporting this.
> >
> > Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh")
> > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
Thank you!
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bpfilter: re-add header search paths to tools include to fix build error
2019-02-22 3:23 [PATCH] bpfilter: re-add header search paths to tools include to fix build error Masahiro Yamada
2019-02-22 5:54 ` Guenter Roeck
@ 2019-02-23 21:36 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2019-02-23 21:36 UTC (permalink / raw)
To: yamada.masahiro
Cc: netdev, linux, songliubraving, ast, yhs, linux-kernel, kafai, daniel
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Fri, 22 Feb 2019 12:23:19 +0900
> I thought header search paths to tools/include(/uapi) were unneeded,
> but it looks like a build error occurs depending on the compiler.
>
> Commit 303a339f30a9 ("bpfilter: remove extra header search paths for
> bpfilter_umh") reintroduced the build error fixed by commit ae40832e53c3
> ("bpfilter: fix a build err").
>
> Apology for the breakage, and thanks to Guenter for reporting this.
>
> Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-23 21:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 3:23 [PATCH] bpfilter: re-add header search paths to tools include to fix build error Masahiro Yamada
2019-02-22 5:54 ` Guenter Roeck
2019-02-22 8:23 ` Masahiro Yamada
2019-02-23 21:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).