Re: [PATCH RFC net-next v4 7/7] sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY}

From: Tom Herbert <tom@herbertland.com>
To: Davide Caratti <dcaratti@redhat.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
	David Laight <David.Laight@aculab.com>,
	"David S . Miller" <davem@davemloft.net>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	"linux-sctp @ vger . kernel . org" <linux-sctp@vger.kernel.org>
Subject: Re: [PATCH RFC net-next v4 7/7] sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY}
Date: Sat, 29 Apr 2017 13:20:04 -0700	[thread overview]
Message-ID: <CALx6S36DWL0ChGozD+4zBJ=xCQCtSrUEez11q1Rwbk9QPVmmoA@mail.gmail.com> (raw)
In-Reply-To: <a6f87efa3d7a00deaaddd080cd41be8a5b34387e.1492692976.git.dcaratti@redhat.com>

On Thu, Apr 20, 2017 at 6:38 AM, Davide Caratti <dcaratti@redhat.com> wrote:
> Add FCoE to the list of protocols that can set CHECKSUM_UNNECESSARY; add a
> note to CHECKSUM_COMPLETE section to specify that it does not apply to SCTP
> and FCoE protocols.
>
> Suggested-by: Tom Herbert <tom@herbertland.com>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> ---
>  include/linux/skbuff.h | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 4002c11..c902b77 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -109,6 +109,7 @@
>   *       may perform further validation in this case.
>   *     GRE: only if the checksum is present in the header.
>   *     SCTP: indicates the CRC in SCTP header has been validated.
> + *     FCOE: indicates the CRC in FC frame has been validated.
>   *
>   *   skb->csum_level indicates the number of consecutive checksums found in
>   *   the packet minus one that have been verified as CHECKSUM_UNNECESSARY.
> @@ -126,8 +127,10 @@
>   *   packet as seen by netif_rx() and fills out in skb->csum. Meaning, the
>   *   hardware doesn't need to parse L3/L4 headers to implement this.
>   *
> - *   Note: Even if device supports only some protocols, but is able to produce
> - *   skb->csum, it MUST use CHECKSUM_COMPLETE, not CHECKSUM_UNNECESSARY.
> + *   Notes:
> + *   - Even if device supports only some protocols, but is able to produce
> + *     skb->csum, it MUST use CHECKSUM_COMPLETE, not CHECKSUM_UNNECESSARY.
> + *   - CHECKSUM_COMPLETE is not applicable to SCTP and FCoE protocols.
>   *
>   * CHECKSUM_PARTIAL:
>   *
> --
> 2.7.4
>

Acked-by: Tom Herbert <tom@herbertland.com>