* [PATCH net-next] net/mlx5e: Fix code style issue in mlx driver
@ 2019-01-29 20:31 xiangxia.m.yue
2019-01-31 20:49 ` Or Gerlitz
0 siblings, 1 reply; 4+ messages in thread
From: xiangxia.m.yue @ 2019-01-29 20:31 UTC (permalink / raw)
To: saeedm, gerlitz.or; +Cc: netdev, Tonghao Zhang
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Add the tab before '}' and keep the code style consistent.
Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
index 79f122b..9c5aac1 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -618,7 +618,8 @@ static struct mlx5_flow_group *alloc_flow_group(struct mlx5_flow_steering *steer
if (ret) {
kmem_cache_free(steering->fgs_cache, fg);
return ERR_PTR(ret);
-}
+ }
+
ida_init(&fg->fte_allocator);
fg->mask.match_criteria_enable = match_criteria_enable;
memcpy(&fg->mask.match_criteria, match_criteria,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/mlx5e: Fix code style issue in mlx driver
2019-01-29 20:31 [PATCH net-next] net/mlx5e: Fix code style issue in mlx driver xiangxia.m.yue
@ 2019-01-31 20:49 ` Or Gerlitz
2019-01-31 20:51 ` Or Gerlitz
0 siblings, 1 reply; 4+ messages in thread
From: Or Gerlitz @ 2019-01-31 20:49 UTC (permalink / raw)
To: Tonghao Zhang, David Miller; +Cc: Saeed Mahameed, Linux Netdev List
On Thu, Jan 31, 2019 at 4:11 PM <xiangxia.m.yue@gmail.com> wrote:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> Add the tab before '}' and keep the code style consistent.
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
LGTM
Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/mlx5e: Fix code style issue in mlx driver
2019-01-31 20:49 ` Or Gerlitz
@ 2019-01-31 20:51 ` Or Gerlitz
2019-02-01 1:12 ` Tonghao Zhang
0 siblings, 1 reply; 4+ messages in thread
From: Or Gerlitz @ 2019-01-31 20:51 UTC (permalink / raw)
To: Tonghao Zhang, David Miller; +Cc: Saeed Mahameed, Linux Netdev List
On Thu, Jan 31, 2019 at 10:49 PM Or Gerlitz <gerlitz.or@gmail.com> wrote:
>
> On Thu, Jan 31, 2019 at 4:11 PM <xiangxia.m.yue@gmail.com> wrote:
> > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> >
> > Add the tab before '}' and keep the code style consistent.
> >
> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> LGTM
> Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
oops, for files starting with en_ prefix we use net/mlx5e: prefix for the patch
title (ethernet) and for the others net/mlx5: (core) -- please fix and
re-send, add my R.B
and also make sure to copy Dave Miller
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/mlx5e: Fix code style issue in mlx driver
2019-01-31 20:51 ` Or Gerlitz
@ 2019-02-01 1:12 ` Tonghao Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Tonghao Zhang @ 2019-02-01 1:12 UTC (permalink / raw)
To: Or Gerlitz; +Cc: David Miller, Saeed Mahameed, Linux Netdev List
On Fri, Feb 1, 2019 at 4:51 AM Or Gerlitz <gerlitz.or@gmail.com> wrote:
>
> On Thu, Jan 31, 2019 at 10:49 PM Or Gerlitz <gerlitz.or@gmail.com> wrote:
> >
> > On Thu, Jan 31, 2019 at 4:11 PM <xiangxia.m.yue@gmail.com> wrote:
> > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > >
> > > Add the tab before '}' and keep the code style consistent.
> > >
> > > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> >
> > LGTM
>
> > Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
>
> oops, for files starting with en_ prefix we use net/mlx5e: prefix for the patch
> title (ethernet) and for the others net/mlx5: (core) -- please fix and
OK, thanks for your tips
> re-send, add my R.B
> and also make sure to copy Dave Miller
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-01 1:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 20:31 [PATCH net-next] net/mlx5e: Fix code style issue in mlx driver xiangxia.m.yue
2019-01-31 20:49 ` Or Gerlitz
2019-01-31 20:51 ` Or Gerlitz
2019-02-01 1:12 ` Tonghao Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).