* [PATCH net-next v2] Documentation: add a description for net.core.high_order_alloc_disable
@ 2022-07-07 8:02 Antoine Tenart
2022-07-07 8:10 ` Eric Dumazet
2022-07-09 3:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Antoine Tenart @ 2022-07-07 8:02 UTC (permalink / raw)
To: davem, kuba, pabeni, edumazet; +Cc: Antoine Tenart, netdev
A description is missing for the net.core.high_order_alloc_disable
option in admin-guide/sysctl/net.rst ; add it. The above sysctl option
was introduced by commit ce27ec60648d ("net: add high_order_alloc_disable
sysctl/static key").
Thanks to Eric for running again the benchmark cited in the above
commit, showing this knob is now mostly of historical importance.
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: Antoine Tenart <atenart@kernel.org>
---
Since v1:
- Reworked the documentation to mention this knob is now mostly of
historical importance after Eric ran again the benchmark cited in
the above commit.
Documentation/admin-guide/sysctl/net.rst | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst
index fcd650bdbc7e..805f2281e000 100644
--- a/Documentation/admin-guide/sysctl/net.rst
+++ b/Documentation/admin-guide/sysctl/net.rst
@@ -391,6 +391,18 @@ GRO has decided not to coalesce, it is placed on a per-NAPI list. This
list is then passed to the stack when the number of segments reaches the
gro_normal_batch limit.
+high_order_alloc_disable
+------------------------
+
+By default the allocator for page frags tries to use high order pages (order-3
+on x86). While the default behavior gives good results in most cases, some users
+might have hit a contention in page allocations/freeing. This was especially
+true on older kernels (< 5.14) when high-order pages were not stored on per-cpu
+lists. This allows to opt-in for order-0 allocation instead but is now mostly of
+historical importance.
+
+Default: 0
+
2. /proc/sys/net/unix - Parameters for Unix domain sockets
----------------------------------------------------------
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] Documentation: add a description for net.core.high_order_alloc_disable
2022-07-07 8:02 [PATCH net-next v2] Documentation: add a description for net.core.high_order_alloc_disable Antoine Tenart
@ 2022-07-07 8:10 ` Eric Dumazet
2022-07-09 3:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2022-07-07 8:10 UTC (permalink / raw)
To: Antoine Tenart; +Cc: David Miller, Jakub Kicinski, Paolo Abeni, netdev
On Thu, Jul 7, 2022 at 10:02 AM Antoine Tenart <atenart@kernel.org> wrote:
>
> A description is missing for the net.core.high_order_alloc_disable
> option in admin-guide/sysctl/net.rst ; add it. The above sysctl option
> was introduced by commit ce27ec60648d ("net: add high_order_alloc_disable
> sysctl/static key").
>
> Thanks to Eric for running again the benchmark cited in the above
> commit, showing this knob is now mostly of historical importance.
>
> Cc: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Antoine Tenart <atenart@kernel.org>
> ---
Reviewed-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] Documentation: add a description for net.core.high_order_alloc_disable
2022-07-07 8:02 [PATCH net-next v2] Documentation: add a description for net.core.high_order_alloc_disable Antoine Tenart
2022-07-07 8:10 ` Eric Dumazet
@ 2022-07-09 3:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-09 3:20 UTC (permalink / raw)
To: Antoine Tenart; +Cc: davem, kuba, pabeni, edumazet, netdev
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 7 Jul 2022 10:02:45 +0200 you wrote:
> A description is missing for the net.core.high_order_alloc_disable
> option in admin-guide/sysctl/net.rst ; add it. The above sysctl option
> was introduced by commit ce27ec60648d ("net: add high_order_alloc_disable
> sysctl/static key").
>
> Thanks to Eric for running again the benchmark cited in the above
> commit, showing this knob is now mostly of historical importance.
>
> [...]
Here is the summary with links:
- [net-next,v2] Documentation: add a description for net.core.high_order_alloc_disable
https://git.kernel.org/netdev/net-next/c/40ad0a52ef5d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-09 3:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-07 8:02 [PATCH net-next v2] Documentation: add a description for net.core.high_order_alloc_disable Antoine Tenart
2022-07-07 8:10 ` Eric Dumazet
2022-07-09 3:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).