* [PATCH v3 net-next 1/1] plca.c: fix obvious mistake in checking retval
@ 2023-01-13 13:26 Piergiorgio Beruto
2023-01-13 13:32 ` Eric Dumazet
2023-01-14 5:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Piergiorgio Beruto @ 2023-01-13 13:26 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: linux-kernel, netdev, Oleksij Rempel, mailhol.vincent,
sudheer.mogilappagari, sbhatta, linux-doc, wangjie125, corbet,
lkp, gal, gustavoars, bagasdotme
Revert a wrong fix that was done during the review process. The
intention was to substitute "if(ret < 0)" with "if(ret)".
Unfortunately, the intended fix did not meet the code.
Besides, after additional review, it was decided that "if(ret < 0)"
was actually the right thing to do.
Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS")
Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
net/ethtool/plca.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/ethtool/plca.c b/net/ethtool/plca.c
index d9bb13ffc654..be7404dc9ef2 100644
--- a/net/ethtool/plca.c
+++ b/net/ethtool/plca.c
@@ -61,7 +61,7 @@ static int plca_get_cfg_prepare_data(const struct ethnl_req_info *req_base,
}
ret = ethnl_ops_begin(dev);
- if (!ret)
+ if (ret < 0)
goto out;
memset(&data->plca_cfg, 0xff,
@@ -151,7 +151,7 @@ int ethnl_set_plca_cfg(struct sk_buff *skb, struct genl_info *info)
tb[ETHTOOL_A_PLCA_HEADER],
genl_info_net(info), info->extack,
true);
- if (!ret)
+ if (ret < 0)
return ret;
dev = req_info.dev;
@@ -171,7 +171,7 @@ int ethnl_set_plca_cfg(struct sk_buff *skb, struct genl_info *info)
}
ret = ethnl_ops_begin(dev);
- if (!ret)
+ if (ret < 0)
goto out_rtnl;
memset(&plca_cfg, 0xff, sizeof(plca_cfg));
@@ -189,7 +189,7 @@ int ethnl_set_plca_cfg(struct sk_buff *skb, struct genl_info *info)
goto out_ops;
ret = ops->set_plca_cfg(dev->phydev, &plca_cfg, info->extack);
- if (!ret)
+ if (ret < 0)
goto out_ops;
ethtool_notify(dev, ETHTOOL_MSG_PLCA_NTF, NULL);
@@ -233,7 +233,7 @@ static int plca_get_status_prepare_data(const struct ethnl_req_info *req_base,
}
ret = ethnl_ops_begin(dev);
- if (!ret)
+ if (ret < 0)
goto out;
memset(&data->plca_st, 0xff,
--
2.37.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 net-next 1/1] plca.c: fix obvious mistake in checking retval
2023-01-13 13:26 [PATCH v3 net-next 1/1] plca.c: fix obvious mistake in checking retval Piergiorgio Beruto
@ 2023-01-13 13:32 ` Eric Dumazet
2023-01-14 5:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2023-01-13 13:32 UTC (permalink / raw)
To: Piergiorgio Beruto
Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Jakub Kicinski, Paolo Abeni, linux-kernel, netdev,
Oleksij Rempel, mailhol.vincent, sudheer.mogilappagari, sbhatta,
linux-doc, wangjie125, corbet, lkp, gal, gustavoars, bagasdotme
On Fri, Jan 13, 2023 at 2:26 PM Piergiorgio Beruto
<piergiorgio.beruto@gmail.com> wrote:
>
> Revert a wrong fix that was done during the review process. The
> intention was to substitute "if(ret < 0)" with "if(ret)".
> Unfortunately, the intended fix did not meet the code.
> Besides, after additional review, it was decided that "if(ret < 0)"
> was actually the right thing to do.
>
> Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS")
> Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 net-next 1/1] plca.c: fix obvious mistake in checking retval
2023-01-13 13:26 [PATCH v3 net-next 1/1] plca.c: fix obvious mistake in checking retval Piergiorgio Beruto
2023-01-13 13:32 ` Eric Dumazet
@ 2023-01-14 5:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-14 5:50 UTC (permalink / raw)
To: Piergiorgio Beruto
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
linux-kernel, netdev, o.rempel, mailhol.vincent,
sudheer.mogilappagari, sbhatta, linux-doc, wangjie125, corbet,
lkp, gal, gustavoars, bagasdotme
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 13 Jan 2023 14:26:35 +0100 you wrote:
> Revert a wrong fix that was done during the review process. The
> intention was to substitute "if(ret < 0)" with "if(ret)".
> Unfortunately, the intended fix did not meet the code.
> Besides, after additional review, it was decided that "if(ret < 0)"
> was actually the right thing to do.
>
> Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS")
> Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> [...]
Here is the summary with links:
- [v3,net-next,1/1] plca.c: fix obvious mistake in checking retval
https://git.kernel.org/netdev/net-next/c/28dbf774bc87
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-14 5:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 13:26 [PATCH v3 net-next 1/1] plca.c: fix obvious mistake in checking retval Piergiorgio Beruto
2023-01-13 13:32 ` Eric Dumazet
2023-01-14 5:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).