* [PATCH 1/1] net: fec: fix crash at mx53 qsb board
@ 2013-02-21 1:07 Frank Li
2013-02-21 2:19 ` Fabio Estevam
2013-02-21 18:04 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Frank Li @ 2013-02-21 1:07 UTC (permalink / raw)
To: lznuaa, davem, linux-arm-kernel, netdev
Cc: shawn.guo, B38611, s.hauer, festevam, Frank Li
Unable to handle kernel NULL pointer dereference at virtual address 00000002
pgd = 80004000
[00000002] *pgd=00000000
Internal error: Oops: 5 [#1] SMP ARM
Modules linked in:
CPU: 0 Not tainted (3.8.0-rc7-next-20130215+ #346)
PC is at fec_enet_interrupt+0xd0/0x348
LR is at fec_enet_interrupt+0xb8/0x348
pc : [<80372b7c>] lr : [<80372b64>] psr: 60000193
sp : df855c20 ip : df855c20 fp : df855c74
r10: 00000516 r9 : 1c000000 r8 : 00000000
r7 : 00000000 r6 : 00000000 r5 : 00000000 r4 : df9b7800
r3 : df9b7df4 r2 : 00000000 r1 : 00000000 r0 : df9b7d34
It is possible that issue a irq between request_irq and fec_enet_init.
Irq handle will be called but driver data structure is not ready yet.
Signed-off-by: Frank Li <Frank.Li@freescale.com>
---
drivers/net/ethernet/freescale/fec.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
index 7c6e890..a860486 100644
--- a/drivers/net/ethernet/freescale/fec.c
+++ b/drivers/net/ethernet/freescale/fec.c
@@ -1676,7 +1676,6 @@ static int fec_enet_init(struct net_device *ndev)
ndev->netdev_ops = &fec_netdev_ops;
ndev->ethtool_ops = &fec_enet_ethtool_ops;
- writel(FEC_RX_DISABLED_IMASK, fep->hwp + FEC_IMASK);
netif_napi_add(ndev, &fep->napi, fec_enet_rx_napi, FEC_NAPI_WEIGHT);
/* Init enet descriptors */
@@ -1786,6 +1785,13 @@ fec_probe(struct platform_device *pdev)
fep->pdev = pdev;
fep->dev_id = dev_id++;
+ /*
+ * disable and clean all irq to avoid unexpected irq happen
+ * between init driver data structure and request_irq
+ */
+ writel(0, fep->hwp + FEC_IMASK);
+ writel(0xFFFFFFFF, fep->hwp + FEC_IEVENT);
+
fep->bufdesc_ex = 0;
if (!fep->hwp) {
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net: fec: fix crash at mx53 qsb board
2013-02-21 1:07 [PATCH 1/1] net: fec: fix crash at mx53 qsb board Frank Li
@ 2013-02-21 2:19 ` Fabio Estevam
2013-02-21 18:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2013-02-21 2:19 UTC (permalink / raw)
To: Frank Li
Cc: lznuaa, davem, linux-arm-kernel, netdev, shawn.guo, B38611, s.hauer
On Wed, Feb 20, 2013 at 10:07 PM, Frank Li <Frank.Li@freescale.com> wrote:
> Unable to handle kernel NULL pointer dereference at virtual address 00000002
> pgd = 80004000
> [00000002] *pgd=00000000
> Internal error: Oops: 5 [#1] SMP ARM
> Modules linked in:
> CPU: 0 Not tainted (3.8.0-rc7-next-20130215+ #346)
> PC is at fec_enet_interrupt+0xd0/0x348
> LR is at fec_enet_interrupt+0xb8/0x348
> pc : [<80372b7c>] lr : [<80372b64>] psr: 60000193
> sp : df855c20 ip : df855c20 fp : df855c74
> r10: 00000516 r9 : 1c000000 r8 : 00000000
> r7 : 00000000 r6 : 00000000 r5 : 00000000 r4 : df9b7800
> r3 : df9b7df4 r2 : 00000000 r1 : 00000000 r0 : df9b7d34
>
> It is possible that issue a irq between request_irq and fec_enet_init.
> Irq handle will be called but driver data structure is not ready yet.
>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net: fec: fix crash at mx53 qsb board
2013-02-21 1:07 [PATCH 1/1] net: fec: fix crash at mx53 qsb board Frank Li
2013-02-21 2:19 ` Fabio Estevam
@ 2013-02-21 18:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-02-21 18:04 UTC (permalink / raw)
To: Frank.Li
Cc: lznuaa, linux-arm-kernel, netdev, shawn.guo, B38611, s.hauer, festevam
From: Frank Li <Frank.Li@freescale.com>
Date: Thu, 21 Feb 2013 09:07:28 +0800
> Unable to handle kernel NULL pointer dereference at virtual address 00000002
> pgd = 80004000
> [00000002] *pgd=00000000
> Internal error: Oops: 5 [#1] SMP ARM
> Modules linked in:
> CPU: 0 Not tainted (3.8.0-rc7-next-20130215+ #346)
> PC is at fec_enet_interrupt+0xd0/0x348
> LR is at fec_enet_interrupt+0xb8/0x348
> pc : [<80372b7c>] lr : [<80372b64>] psr: 60000193
> sp : df855c20 ip : df855c20 fp : df855c74
> r10: 00000516 r9 : 1c000000 r8 : 00000000
> r7 : 00000000 r6 : 00000000 r5 : 00000000 r4 : df9b7800
> r3 : df9b7df4 r2 : 00000000 r1 : 00000000 r0 : df9b7d34
>
> It is possible that issue a irq between request_irq and fec_enet_init.
> Irq handle will be called but driver data structure is not ready yet.
>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
You must fix this by making sure all of the necessary software
datastructures are initialized fully before request_irq() is
invoked.
You absolutely cannot control pending interrupts the chip is already
signalling and which have been queued up in the interrupt controller
already, which will be emitted precisely when you request_irq()
regardless of how you program the chip during this time.
I'm not applying this, fix the bug correctly, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-21 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-21 1:07 [PATCH 1/1] net: fec: fix crash at mx53 qsb board Frank Li
2013-02-21 2:19 ` Fabio Estevam
2013-02-21 18:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).