From: Pravin Shelar <pshelar@ovn.org>
To: Martin Varghese <martinvarghesenokia@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"Varghese,
Martin (Nokia - IN/Bangalore)" <martin.varghese@nokia.com>
Subject: Re: [PATCH v3 net] Fixed updating of ethertype in function skb_mpls_pop
Date: Mon, 2 Dec 2019 11:00:53 -0800 [thread overview]
Message-ID: <CAOrHB_B8+PG=-TkVU2eOa5jAgBKBTpi8nt7z20Y7Ej0yP6=Oug@mail.gmail.com> (raw)
In-Reply-To: <1575263991-5915-1-git-send-email-martinvarghesenokia@gmail.com>
On Sun, Dec 1, 2019 at 9:20 PM Martin Varghese
<martinvarghesenokia@gmail.com> wrote:
>
> From: Martin Varghese <martin.varghese@nokia.com>
>
> The skb_mpls_pop was not updating ethertype of an ethernet packet if the
> packet was originally received from a non ARPHRD_ETHER device.
>
> In the below OVS data path flow, since the device corresponding to port 7
> is an l3 device (ARPHRD_NONE) the skb_mpls_pop function does not update
> the ethertype of the packet even though the previous push_eth action had
> added an ethernet header to the packet.
>
> recirc_id(0),in_port(7),eth_type(0x8847),
> mpls(label=12/0xfffff,tc=0/0,ttl=0/0x0,bos=1/1),
> actions:push_eth(src=00:00:00:00:00:00,dst=00:00:00:00:00:00),
> pop_mpls(eth_type=0x800),4
>
> Fixes: ed246cee09b9 ("net: core: move pop MPLS functionality from OvS to core helper")
> Signed-off-by: Martin Varghese <martin.varghese@nokia.com>
> ---
> Changes in v2:
> - In function skb_mpls_pop check for dev type removed
> while updating ethertype.
> - key->mac_proto is checked in function pop_mpls to pass
> ethernet flag to skb_mpls_pop.
> - dev type is checked in function tcf_mpls_act to pass
> ethernet flag to skb_mpls_pop.
>
> Changes in v3:
> - Fixed header inclusion order.
> - Removed unwanted braces.
> - Retain space between function argements and description in the
> coments of function skb_mpls_pop.
> - used ovs_key_mac_proto(key) to check if the packet is ethernet.
> - Added fixes tag.
>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
next prev parent reply other threads:[~2019-12-02 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 5:19 [PATCH v3 net] Fixed updating of ethertype in function skb_mpls_pop Martin Varghese
2019-12-02 19:00 ` Pravin Shelar [this message]
2019-12-02 21:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOrHB_B8+PG=-TkVU2eOa5jAgBKBTpi8nt7z20Y7Ej0yP6=Oug@mail.gmail.com' \
--to=pshelar@ovn.org \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=martin.varghese@nokia.com \
--cc=martinvarghesenokia@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).