From: David Miller <davem@davemloft.net>
To: martinvarghesenokia@gmail.com
Cc: netdev@vger.kernel.org, pshelar@ovn.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us,
martin.varghese@nokia.com
Subject: Re: [PATCH v3 net] Fixed updating of ethertype in function skb_mpls_pop
Date: Mon, 02 Dec 2019 13:04:23 -0800 (PST) [thread overview]
Message-ID: <20191202.130423.1014387604144365216.davem@davemloft.net> (raw)
In-Reply-To: <1575263991-5915-1-git-send-email-martinvarghesenokia@gmail.com>
From: Martin Varghese <martinvarghesenokia@gmail.com>
Date: Mon, 2 Dec 2019 10:49:51 +0530
> From: Martin Varghese <martin.varghese@nokia.com>
>
> The skb_mpls_pop was not updating ethertype of an ethernet packet if the
> packet was originally received from a non ARPHRD_ETHER device.
>
> In the below OVS data path flow, since the device corresponding to port 7
> is an l3 device (ARPHRD_NONE) the skb_mpls_pop function does not update
> the ethertype of the packet even though the previous push_eth action had
> added an ethernet header to the packet.
>
> recirc_id(0),in_port(7),eth_type(0x8847),
> mpls(label=12/0xfffff,tc=0/0,ttl=0/0x0,bos=1/1),
> actions:push_eth(src=00:00:00:00:00:00,dst=00:00:00:00:00:00),
> pop_mpls(eth_type=0x800),4
>
> Fixes: ed246cee09b9 ("net: core: move pop MPLS functionality from OvS to core helper")
> Signed-off-by: Martin Varghese <martin.varghese@nokia.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2019-12-02 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 5:19 [PATCH v3 net] Fixed updating of ethertype in function skb_mpls_pop Martin Varghese
2019-12-02 19:00 ` Pravin Shelar
2019-12-02 21:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202.130423.1014387604144365216.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=martin.varghese@nokia.com \
--cc=martinvarghesenokia@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).