* [PATCH] can: flexcan: Fix runtime PM imbalance on error
@ 2020-05-22 9:43 Dinghao Liu
2020-05-25 1:36 ` Joakim Zhang
0 siblings, 1 reply; 2+ messages in thread
From: Dinghao Liu @ 2020-05-22 9:43 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller,
Jakub Kicinski, linux-can, netdev, linux-kernel
When register_flexcandev() returns an error code, a
pairing runtime PM usage counter decrement is needed
to keep the counter balanced.
Also, call pm_runtime_disable() when register_flexcandev()
returns an error code.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
drivers/net/can/flexcan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 94d10ec954a0..ea193426e5ae 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -1666,6 +1666,8 @@ static int flexcan_probe(struct platform_device *pdev)
return 0;
failed_register:
+ pm_runtime_put_noidle(&pdev->dev);
+ pm_runtime_disable(&pdev->dev);
free_candev(dev);
return err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] can: flexcan: Fix runtime PM imbalance on error
2020-05-22 9:43 [PATCH] can: flexcan: Fix runtime PM imbalance on error Dinghao Liu
@ 2020-05-25 1:36 ` Joakim Zhang
0 siblings, 0 replies; 2+ messages in thread
From: Joakim Zhang @ 2020-05-25 1:36 UTC (permalink / raw)
To: Dinghao Liu, kjlu
Cc: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller,
Jakub Kicinski, linux-can, netdev, linux-kernel
> -----Original Message-----
> From: linux-can-owner@vger.kernel.org <linux-can-owner@vger.kernel.org>
> On Behalf Of Dinghao Liu
> Sent: 2020年5月22日 17:44
> To: dinghao.liu@zju.edu.cn; kjlu@umn.edu
> Cc: Wolfgang Grandegger <wg@grandegger.com>; Marc Kleine-Budde
> <mkl@pengutronix.de>; David S. Miller <davem@davemloft.net>; Jakub
> Kicinski <kuba@kernel.org>; linux-can@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] can: flexcan: Fix runtime PM imbalance on error
>
> When register_flexcandev() returns an error code, a pairing runtime PM
> usage counter decrement is needed to keep the counter balanced.
>
> Also, call pm_runtime_disable() when register_flexcandev() returns an error
> code.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
A patch has already been sent out to fix this issue:
https://www.spinics.net/lists/linux-can/msg03052.html
Reviewed-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Best Regards,
Joakim Zhang
> ---
> drivers/net/can/flexcan.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index
> 94d10ec954a0..ea193426e5ae 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -1666,6 +1666,8 @@ static int flexcan_probe(struct platform_device
> *pdev)
> return 0;
>
> failed_register:
> + pm_runtime_put_noidle(&pdev->dev);
> + pm_runtime_disable(&pdev->dev);
> free_candev(dev);
> return err;
> }
> --
> 2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-25 1:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 9:43 [PATCH] can: flexcan: Fix runtime PM imbalance on error Dinghao Liu
2020-05-25 1:36 ` Joakim Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).